git-gui: avoid auto_execok in do_windows_shortcut

mark987 · ttaylorr · commit 00c7aa86e905 · 2025-05-23T17:04:23.000-04:00
git-gui on Windows uses auto_execok to locate git-gui.exe,
which performs the same flawed search as does the builtin exec.
Use _which instead, performing a safe PATH lookup.

Signed-off-by: Mark Levedahl &lt;mlevedahl@gmail.com&gt;
Signed-off-by: Johannes Sixt &lt;j6t@kdbg.org&gt;
Signed-off-by: Taylor Blau &lt;me@ttaylorr.com&gt;
diff --git a/lib/shortcut.tcl b/lib/shortcut.tcl
@@ -12,7 +12,7 @@ proc do_windows_shortcut {} {
 			set fn ${fn}.lnk
 		}
 		# Use git-gui.exe if available (ie: git-for-windows)
-		set cmdLine [auto_execok git-gui.exe]
+		set cmdLine [list [_which git-gui]]
 		if {$cmdLine eq {}} {
 			set cmdLine [list [info nameofexecutable] \
 							 [file normalize $::argv0]]

Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ proc do_windows_shortcut {} {`
`12`	`12`	`set fn ${fn}.lnk`
`13`	`13`	`}`
`14`	`14`	`# Use git-gui.exe if available (ie: git-for-windows)`
`15`		`- set cmdLine [auto_execok git-gui.exe]`
	`15`	`+ set cmdLine [list [_which git-gui]]`
`16`	`16`	`if {$cmdLine eq {}} {`
`17`	`17`	`set cmdLine [list [info nameofexecutable] \`
`18`	`18`	`[file normalize $::argv0]]`