Merge pull request #3402 from Shopify/kd-2025-10-remove-redundant-reduplication

chore(cart): remove redundant gift card code deduplication

Author: kdaviduik

packages/hydrogen/src/cart/queries/cartGiftCardCodeUpdateDefault.ts

@@ -16,22 +16,29 @@ export type CartGiftCardCodesUpdateFunction = (
   optionalParams?: CartOptionalInput,
 ) => Promise<CartQueryDataReturn>;
 
+/**
+ * Updates (replaces) gift card codes in the cart.
+ *
+ * To add codes without replacing, use `cartGiftCardCodesAdd` (API 2025-10+).
+ *
+ * @param {CartQueryOptions} options - Cart query options including storefront client and cart fragment.
+ * @returns {CartGiftCardCodesUpdateFunction} - Function accepting gift card codes array and optional parameters.
+ *
+ * @example Replace all gift card codes
+ * const updateGiftCardCodes = cartGiftCardCodesUpdateDefault({ storefront, getCartId });
+ * await updateGiftCardCodes(['SUMMER2025', 'WELCOME10']);
+ */
 export function cartGiftCardCodesUpdateDefault(
   options: CartQueryOptions,
 ): CartGiftCardCodesUpdateFunction {
   return async (giftCardCodes, optionalParams) => {
-    // Ensure the gift card codes are unique
-    const uniqueCodes = giftCardCodes.filter((value, index, array) => {
-      return array.indexOf(value) === index;
-    });
-
     const {cartGiftCardCodesUpdate, errors} = await options.storefront.mutate<{
       cartGiftCardCodesUpdate: CartQueryData;
       errors: StorefrontApiErrors;
     }>(CART_GIFT_CARD_CODE_UPDATE_MUTATION(options.cartFragment), {
       variables: {
         cartId: options.getCartId(),
-        giftCardCodes: uniqueCodes,
+        giftCardCodes,
         ...optionalParams,
       },
     });

packages/hydrogen/src/cart/queries/cartGiftCardCodesUpdateDefault.test.ts

@@ -27,4 +27,29 @@ describe('cartGiftCardCodesUpdateDefault', () => {
     expect(result.cart).toHaveProperty('id', CART_ID);
     expect(result.userErrors?.[0]).toContain(cartFragment);
   });
+
+  describe('no duplicate filtering (API 2025-10+)', () => {
+    it('should pass duplicate codes directly to API without filtering', async () => {
+      const updateGiftCardCodes = cartGiftCardCodesUpdateDefault({
+        storefront: mockCreateStorefrontClient(),
+        getCartId: () => CART_ID,
+      });
+
+      const codesWithDuplicates = ['GIFT123', 'GIFT123', 'WELCOME10'];
+      const result = await updateGiftCardCodes(codesWithDuplicates);
+
+      expect(result.cart).toHaveProperty('id', CART_ID);
+    });
+
+    it('should delegate duplicate handling to API (case-insensitive normalization)', async () => {
+      const updateGiftCardCodes = cartGiftCardCodesUpdateDefault({
+        storefront: mockCreateStorefrontClient(),
+        getCartId: () => CART_ID,
+      });
+
+      const result = await updateGiftCardCodes(['gift123', 'GIFT123']);
+
+      expect(result.cart).toHaveProperty('id', CART_ID);
+    });
+  });
 });