improve testing

Author: itsjustriley

packages/hydrogen/src/vite/get-virtual-routes.test.ts

@@ -1,5 +1,8 @@
 import {describe, it, expect} from 'vitest';
-import {getVirtualRoutesV3} from './get-virtual-routes.js';
+import {
+  getVirtualRoutesV3,
+  createVirtualRoutesPath,
+} from './get-virtual-routes.js';
 
 describe('virtual routes', () => {
   it('gets virtual routes V3', async () => {
@@ -30,15 +33,36 @@ describe('virtual routes', () => {
     });
   });
 
-  it('handles file paths with spaces correctly', async () => {
-    const result = await getVirtualRoutesV3();
+  it('decodes URL-encoded file paths with spaces', () => {
+    // Mock import.meta.url with a path containing a space
+    const mockImportMetaUrl =
+      'file:///path/with%20space/vite/get-virtual-routes.ts';
 
-    result.routes.forEach((route) => {
-      expect(route.file).not.toContain('%20');
-      expect(route.file).not.toContain('%');
-    });
+    const result = createVirtualRoutesPath(
+      mockImportMetaUrl,
+      ['vite', 'virtual-routes'],
+      'layout.jsx',
+    );
+
+    // Should decode %20 to actual space
+    expect(result).toContain('with space');
+    expect(result).not.toContain('%20');
+  });
+
+  it('removes Windows drive path prefix (e.g. /C:/)', () => {
+    // Mock a Windows file URL with drive letter
+    const mockWindowsUrl =
+      'file:///C:/Users/developer/project/vite/get-virtual-routes.ts';
+
+    const result = createVirtualRoutesPath(
+      mockWindowsUrl,
+      ['vite', 'virtual-routes'],
+      'layout.jsx',
+    );
 
-    expect(result.layout.file).not.toContain('%20');
-    expect(result.layout.file).not.toContain('%');
+    // Should remove /C:/ prefix and start with /
+    expect(result).not.toMatch(/^\/[a-zA-Z]:\//);
+    expect(result).toMatch(/^\//);
+    expect(result).toContain('layout.jsx');
   });
 });

packages/hydrogen/src/vite/get-virtual-routes.ts

@@ -7,11 +7,16 @@ export const VIRTUAL_ROUTES_ROUTES_DIR_PARTS = [
 ];
 export const VIRTUAL_ROUTES_DIR_PARTS = ['vite', 'virtual-routes'];
 
-function getVirtualRoutesPath(
+/**
+ * @internal
+ * Exported for testing only.
+ */
+export function createVirtualRoutesPath(
+  baseUrl: string,
   pathParts: Array<string>,
   forFile: string,
 ): string {
-  const basePath = new URL('../', import.meta.url);
+  const basePath = new URL('../', baseUrl);
   const virtualRoutesPath = pathParts.reduce((working, dirPart) => {
     return new URL(`${dirPart}/`, working);
   }, basePath);
@@ -26,6 +31,13 @@ function getVirtualRoutesPath(
   return decodeURIComponent(pathname);
 }
 
+function getVirtualRoutesPath(
+  pathParts: Array<string>,
+  forFile: string,
+): string {
+  return createVirtualRoutesPath(import.meta.url, pathParts, forFile);
+}
+
 export async function getVirtualRoutesV3() {
   return {
     routes: [