Closed
Conversation
Contributor
fredericoo
commented
Feb 25, 2026
fredericoo
commented
- test: playwright 4 workers
- ci: timeout for e2e
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
fredericoo
changed the title
fredericoo
changed the title
fredericoo
changed the title
fredericoo
commented
Feb 25, 2026
| name: ⬣ E2E tests | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 15 | ||
| timeout-minutes: 30 |
Contributor
Author
There was a problem hiding this comment.
timeout here means we take into account installing browsers, building the stuff etc
we do not want it to timeout if browsers hang or something else
fredericoo
commented
Feb 25, 2026
|
|
||
| - name: 🧪 Run E2E tests | ||
| run: pnpm exec playwright test --workers=1 | ||
| timeout-minutes: 15 |
Contributor
Author
There was a problem hiding this comment.
but this is correct, accounting for only the time it takes to run the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.