Merge pull request #2 from Shopify/limit-with-arguments

support arguments for throttled methods

Author: sbfaulkner

CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## v1.0.1
+
+- BUGFIX: support arguments for throttled methods
+
 ## v1.0.0
 
 - initial release

lib/limiter/mixin.rb

@@ -6,9 +6,9 @@ def limit_method(method, rate:, interval: 60)
       queue = RateQueue.new(rate, interval: interval)
 
       mixin = Module.new do
-        define_method(method) do
+        define_method(method) do |*args|
           queue.shift
-          super()
+          super(*args)
         end
       end
 

lib/limiter/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Limiter
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

test/limiter/mixin_test.rb

@@ -22,8 +22,8 @@ def initialize
         @ticks = 0
       end
 
-      def tick
-        @ticks += 1
+      def tick(count = 1)
+        @ticks += count
       end
     end
 
@@ -47,5 +47,10 @@ def test_original_method_is_called
 
       assert_equal COUNT, @object.ticks
     end
+
+    def test_arguments_are_passed
+      @object.tick 123
+      assert_equal 123, @object.ticks
+    end
   end
 end