Higher order and late binding inline snippets

[jg-rp]

I like inline snippets and I like the simplicity of {% snippet %} sharing the same namespace as {% assign %} and {% capture %} - you get snippet scoping for free.

However, while testing the implementation of {% snippet %} and the changes to {% render %}, I noticed some things that weren't immediately obvious to me:

• We can pass an inline snippet to another snippet as an argument.
• We can overwrite an inline snippet with non-snippet data.
• Snippet blocks are bound to their names when they are rendered, not when they are parsed. (edit: Having given this some more thought, this is inconsequential. Somewhere in my subconscious I must have been thinking that we might want to disallow {% snippet %} inside control flow blocks and {% for %}, but continue to allow nested inline snippets.)

Here's an example that made me pause:

require "liquid"

source = <<~LIQUID
  {% snippet div %}
    {% assign y = 42 -%}
    <div>
      {% render content, y:y %}
    </div>
  {% endsnippet -%}

  {% if x -%}
    {% snippet content %}
      foo {{ y }}
    {% endsnippet %}
  {% else -%}
    {% snippet content %}
      bar {{ y }}
    {% endsnippet %}
  {% endif -%}

  {% snippet more_content %}
    Hi!
  {% endsnippet -%}

  {% render div, content: content -%}
  {% render div, content: more_content -%}
LIQUID

t = Liquid::Template.parse(source, error_mode: :rigid, line_numbers: true)
puts t.render!("x" => false)

Output

  <div>
    
    bar 42
  
  </div>

  <div>
    
  Hi!

  </div>

I'm curious what others think. Are these nice/intentional features, things to be avoided or things that we should prevent?