Merge pull request #344 from Shopify/rafaelfranca-patch-1

Avoid usage of private_constant

Author: etiennebarrie

app/controllers/maintenance_tasks/application_controller.rb

@@ -3,7 +3,7 @@
 module MaintenanceTasks
   # Base class for all controllers used by this engine.
   #
-  # @api private
+  # Can be extended to add different authentication and authorization code.
   class ApplicationController < ActionController::Base
     include Pagy::Backend
 
@@ -22,5 +22,4 @@ class ApplicationController < ActionController::Base
 
     protect_from_forgery with: :exception
   end
-  private_constant :ApplicationController
 end

app/controllers/maintenance_tasks/runs_controller.rb

@@ -30,5 +30,4 @@ def set_run
       @run = Run.find(params.fetch(:id))
     end
   end
-  private_constant :RunsController
 end

app/controllers/maintenance_tasks/tasks_controller.rb

@@ -42,5 +42,4 @@ def set_refresh
       @refresh = 3
     end
   end
-  private_constant :TasksController
 end

app/helpers/maintenance_tasks/application_helper.rb

@@ -29,5 +29,4 @@ def time_ago(datetime)
       end
     end
   end
-  private_constant :ApplicationHelper
 end

app/helpers/maintenance_tasks/tasks_helper.rb

@@ -114,5 +114,4 @@ def csv_file_download_path(run)
       )
     end
   end
-  private_constant :TasksHelper
 end

app/models/maintenance_tasks/application_record.rb

@@ -2,9 +2,9 @@
 module MaintenanceTasks
   # Base class for all records used by this engine.
   #
-  # @api private
+  # Can be extended to setup different database where all tables related to
+  # maintenance tasks will live.
   class ApplicationRecord < ActiveRecord::Base
     self.abstract_class = true
   end
-  private_constant :ApplicationRecord
 end

app/models/maintenance_tasks/csv_collection.rb

@@ -30,5 +30,4 @@ def count
       csv_content.count("\n") - 1
     end
   end
-  private_constant :CsvCollection
 end

app/models/maintenance_tasks/progress.rb

@@ -74,5 +74,4 @@ def over_total?
       @run.tick_count > @run.tick_total
     end
   end
-  private_constant :Progress
 end

app/models/maintenance_tasks/run.rb

@@ -195,5 +195,4 @@ def csv_attachment_presence
       nil
     end
   end
-  private_constant :Run
 end

app/models/maintenance_tasks/task_data.rb

@@ -138,5 +138,4 @@ def runs
       Run.where(task_name: name).with_attached_csv_file.order(created_at: :desc)
     end
   end
-  private_constant :TaskData
 end