Skip to content

Commit 613f637

Browse files
authored
fix small layout bugs in app-settings-layout code example (#8622)
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Found minor discrepancies in the app-settings-layout pattern example. ### WHAT is this pull request doing? * Fixes inconsistent mobile padding for left hand column * Fixes description text not using <Text> component * Adds missing mobile gap to Column component <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
1 parent 74f0bc4 commit 613f637

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

.changeset/few-files-drop.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'polaris.shopify.com': patch
3+
---
4+
5+
Fix minor layout bugs in app-settings-layout pattern code example

polaris.shopify.com/content/patterns/app-settings-layout/variants/default.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -46,19 +46,19 @@ This pattern uses the [`AlphaStack`](/components/layout-and-structure/alpha-stac
4646
]}
4747
>
4848
<AlphaStack gap="16" align="center">
49-
<Columns columns={{xs: '1fr', md: '2fr 5fr'}}>
49+
<Columns columns={{xs: '1fr', md: '2fr 5fr'}} gap="4">
5050
<Box
5151
as="section"
5252
paddingInlineStart={{xs: 4, sm: 0}}
53-
paddingInlineEnd={{xs: 2, sm: 0}}
53+
paddingInlineEnd={{xs: 4, sm: 0}}
5454
>
55-
<AlphaStack align="start" gap="4">
55+
<AlphaStack gap="4">
5656
<Text as="h3" variant="headingMd">
5757
InterJambs
5858
</Text>
59-
<p>
59+
<Text as="p" variant="bodyMd">
6060
Interjambs are the rounded protruding bits of your puzzlie piece
61-
</p>
61+
</Text>
6262
</AlphaStack>
6363
</Box>
6464
<AlphaCard roundedAbove="sm">
@@ -68,19 +68,19 @@ This pattern uses the [`AlphaStack`](/components/layout-and-structure/alpha-stac
6868
</AlphaStack>
6969
</AlphaCard>
7070
</Columns>
71-
<Columns columns={{xs: '1fr', md: '2fr 5fr'}}>
71+
<Columns columns={{xs: '1fr', md: '2fr 5fr'}} gap="4">
7272
<Box
7373
as="section"
74-
paddingInlineStart={{xs: 2, sm: 0}}
75-
paddingInlineEnd={{xs: 2, sm: 0}}
74+
paddingInlineStart={{xs: 4, sm: 0}}
75+
paddingInlineEnd={{xs: 4, sm: 0}}
7676
>
77-
<AlphaStack align="start" gap="4">
77+
<AlphaStack gap="4">
7878
<Text as="h3" variant="headingMd">
7979
Dimensions
8080
</Text>
81-
<p>
81+
<Text as="p" variant="bodyMd">
8282
Interjambs are the rounded protruding bits of your puzzlie piece
83-
</p>
83+
</Text>
8484
</AlphaStack>
8585
</Box>
8686
<AlphaCard roundedAbove="sm">

0 commit comments

Comments
 (0)