Skip to content

Commit 02cefb2

Browse files
authored
Merge pull request rails#52112 from y-yagi/fix_driven_by_for_devcontainer
Correctly output `driven_by` setting for Development Containers
2 parents a2fb851 + 8673f06 commit 02cefb2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/devcontainer-smoke-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
imageTag: postgresql
6464
push: ${{ github.repository_owner == 'rails' && 'filter' || 'never' }}
6565
refFilterForPush: refs/heads/main
66-
runCmd: bin/rails g scaffold Post && bin/rails db:migrate && bin/rails test
66+
runCmd: bin/rails g scaffold Post && bin/rails db:migrate && bin/rails test && bin/rails test:system
6767

6868
- name: Stop all containers
6969
run: docker ps -q | xargs docker stop

railties/lib/rails/generators/rails/devcontainer/devcontainer_generator.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def local_rails_mount
148148
end
149149

150150
def system_test_configuration
151-
<<~RUBY
151+
<<~'RUBY'
152152
if ENV["CAPYBARA_SERVER_PORT"]
153153
served_by host: "rails-app", port: ENV["CAPYBARA_SERVER_PORT"]
154154

0 commit comments

Comments
 (0)