Rename the config to make clear it is a boolean

Author: rafaelfranca

actionview/lib/action_view/helpers/asset_tag_helper.rb

@@ -24,7 +24,7 @@ module AssetTagHelper
       mattr_accessor :image_loading
       mattr_accessor :image_decoding
       mattr_accessor :preload_links_header
-      mattr_accessor :stylesheet_media_default
+      mattr_accessor :apply_stylesheet_media_default
 
       # Returns an HTML script tag for each of the +sources+ provided.
       #
@@ -170,7 +170,7 @@ def stylesheet_link_tag(*sources)
             "href" => href
           }.merge!(options)
 
-          if stylesheet_media_default && tag_options[:media].blank?
+          if apply_stylesheet_media_default && tag_options[:media].blank?
             tag_options[:media] = "screen"
           end
 

actionview/lib/action_view/railtie.rb

@@ -12,7 +12,7 @@ class Railtie < Rails::Engine # :nodoc:
     config.action_view.default_enforce_utf8 = nil
     config.action_view.image_loading = nil
     config.action_view.image_decoding = nil
-    config.action_view.stylesheet_media_default = true
+    config.action_view.apply_stylesheet_media_default = true
 
     config.eager_load_namespaces << ActionView
 
@@ -51,7 +51,7 @@ class Railtie < Rails::Engine # :nodoc:
       ActionView::Helpers::AssetTagHelper.image_loading = app.config.action_view.delete(:image_loading)
       ActionView::Helpers::AssetTagHelper.image_decoding = app.config.action_view.delete(:image_decoding)
       ActionView::Helpers::AssetTagHelper.preload_links_header = app.config.action_view.delete(:preload_links_header)
-      ActionView::Helpers::AssetTagHelper.stylesheet_media_default = app.config.action_view.delete(:stylesheet_media_default)
+      ActionView::Helpers::AssetTagHelper.apply_stylesheet_media_default = app.config.action_view.delete(:apply_apply_stylesheet_media_default)
     end
 
     config.after_initialize do |app|

actionview/test/template/asset_tag_helper_test.rb

@@ -506,13 +506,13 @@ def test_stylesheet_link_tag_with_default_protocol
   end
 
   def test_stylesheet_link_tag_with_configured_stylesheet_media_default
-    original_default_media = ActionView::Helpers::AssetTagHelper.stylesheet_media_default
-    ActionView::Helpers::AssetTagHelper.stylesheet_media_default = true
+    original_default_media = ActionView::Helpers::AssetTagHelper.apply_stylesheet_media_default
+    ActionView::Helpers::AssetTagHelper.apply_stylesheet_media_default = true
 
     assert_dom_equal %(<link href="/file.css" media="screen" rel="stylesheet" />), stylesheet_link_tag("/file")
     assert_dom_equal %(<link href="/file.css" media="all" rel="stylesheet" />), stylesheet_link_tag("/file", media: "all")
   ensure
-    ActionView::Helpers::AssetTagHelper.stylesheet_media_default = original_default_media
+    ActionView::Helpers::AssetTagHelper.apply_stylesheet_media_default = original_default_media
   end
 
   def test_javascript_include_tag_without_request

guides/source/configuring.md

@@ -740,7 +740,7 @@ Defaults to `'signed cookie'`.
 
 * `config.action_view.button_to_generates_button_tag` determines whether `button_to` will render `<button>` element, regardless of whether or not the content is passed as the first argument or as a block.
 
-* `config.action_view.stylesheet_media_default` determines whether `stylesheet_link_tag` will render `screen` as the default value for the attribute `media` when it's not provided.
+* `config.action_view.apply_stylesheet_media_default` determines whether `stylesheet_link_tag` will render `screen` as the default value for the attribute `media` when it's not provided.
 
 ### Configuring Action Mailbox
 
@@ -1049,7 +1049,7 @@ text/javascript image/svg+xml application/postscript application/x-shockwave-fla
 
 #### For '6.2', defaults from previous versions below and:
 - `config.action_view.button_to_generates_button_tag`: `true`
-- `config.action_view.stylesheet_media_default` : `false`
+- `config.action_view.apply_stylesheet_media_default` : `false`
 - `config.active_support.key_generator_hash_digest_class`: `OpenSSL::Digest::SHA256`
 - `config.active_support.hash_digest_class`: `OpenSSL::Digest::SHA256`
 - `config.action_dispatch.return_only_request_media_type_on_content_type`: `false`
@@ -1115,7 +1115,7 @@ text/javascript image/svg+xml application/postscript application/x-shockwave-fla
 - `config.action_view.form_with_generates_ids`: `false`
 - `config.action_view.preload_links_header`: `nil`
 - `config.action_view.button_to_generates_button_tag`: `false`
-- `config.action_view.stylesheet_media_default` : `true`
+- `config.action_view.apply_stylesheet_media_default` : `true`
 - `config.active_job.retry_jitter`: `0.0`
 - `config.active_job.skip_after_callbacks_if_terminated`: `false`
 - `config.action_mailbox.queues.incineration`: `:action_mailbox_incineration`

railties/lib/rails/application/configuration.rb

@@ -208,7 +208,7 @@ def load_defaults(target_version)
 
           if respond_to?(:action_view)
             action_view.button_to_generates_button_tag = true
-            action_view.stylesheet_media_default = false
+            action_view.apply_stylesheet_media_default = false
           end
 
           if respond_to?(:active_support)

railties/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults_6_2.rb.tt

@@ -11,7 +11,7 @@
 # Rails.application.config.action_view.button_to_generates_button_tag = true
 
 # `stylesheet_link_tag` view helper will not render the media attribute by default.
-# Rails.application.config.action_view.stylesheet_media_default = false
+# Rails.application.config.action_view.apply_stylesheet_media_default = false
 
 # Change the digest class for the key generators to `OpenSSL::Digest::SHA256`.
 # Changing this default means invalidate all encrypted messages generated by

railties/test/application/configuration_test.rb

@@ -2455,23 +2455,23 @@ class ::DummySerializer < ActiveJob::Serializers::ObjectSerializer; end
       assert_equal false, ActionView::Helpers::AssetTagHelper.preload_links_header
     end
 
-    test "ActionView::Helpers::AssetTagHelper.stylesheet_media_default is true by default for upgraded apps" do
+    test "ActionView::Helpers::AssetTagHelper.apply_stylesheet_media_default is true by default for upgraded apps" do
       remove_from_config '.*config\.load_defaults.*\n'
       app "development"
 
-      assert_equal true, ActionView::Helpers::AssetTagHelper.stylesheet_media_default
+      assert_equal true, ActionView::Helpers::AssetTagHelper.apply_stylesheet_media_default
     end
 
-    test "ActionView::Helpers::AssetTagHelper.stylesheet_media_default can be configured via config.action_view.stylesheet_media_default" do
+    test "ActionView::Helpers::AssetTagHelper.apply_stylesheet_media_default can be configured via config.action_view.apply_stylesheet_media_default" do
       remove_from_config '.*config\.load_defaults.*\n'
 
       app_file "config/initializers/new_framework_defaults_6_2.rb", <<-RUBY
-        Rails.application.config.action_view.stylesheet_media_default = false
+        Rails.application.config.action_view.apply_stylesheet_media_default = false
       RUBY
 
       app "development"
 
-      assert_equal false, ActionView::Helpers::AssetTagHelper.stylesheet_media_default
+      assert_equal false, ActionView::Helpers::AssetTagHelper.apply_stylesheet_media_default
     end
 
     test "stylesheet_link_tag sets the Link header by default" do