Skip to content

Commit 03998c3

Browse files
authored
Merge pull request rails#55392 from skipkayhil/hm-pqxotpuwomulupko
Fix kill_connection_from_server for PG test
2 parents 7022080 + 8938715 commit 03998c3

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

activerecord/test/cases/adapter_test.rb

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -882,18 +882,7 @@ def teardown
882882
end
883883

884884
test "#execute is retryable" do
885-
conn_id = case @connection.adapter_name
886-
when "Mysql2"
887-
@connection.execute("SELECT CONNECTION_ID()").to_a[0][0]
888-
when "Trilogy"
889-
@connection.execute("SELECT CONNECTION_ID() as connection_id").to_a[0][0]
890-
when "PostgreSQL"
891-
@connection.execute("SELECT pg_backend_pid()").to_a[0]["pg_backend_pid"]
892-
else
893-
skip("kill_connection_from_server unsupported")
894-
end
895-
896-
kill_connection_from_server(conn_id)
885+
kill_connection_from_server
897886

898887
@connection.execute("SELECT 1", allow_retry: true)
899888
end
@@ -964,7 +953,7 @@ def raw_transaction_open?(connection)
964953
true
965954
end
966955
else
967-
skip("kill_connection_from_server unsupported")
956+
skip("raw_transaction_open? unsupported")
968957
end
969958
end
970959

@@ -986,13 +975,15 @@ def remote_disconnect(connection)
986975
end
987976
end
988977

989-
def kill_connection_from_server(connection_id)
978+
def kill_connection_from_server
990979
conn = @connection.pool.checkout
991980
case conn.adapter_name
992981
when "Mysql2", "Trilogy"
982+
connection_id = @connection.execute("SELECT CONNECTION_ID()").to_a[0][0]
993983
conn.execute("KILL #{connection_id}")
994984
when "PostgreSQL"
995-
conn.execute("SELECT pg_cancel_backend(#{connection_id})")
985+
connection_id = @connection.execute("SELECT pg_backend_pid()").to_a[0]["pg_backend_pid"]
986+
conn.execute("SELECT pg_terminate_backend(#{connection_id})")
996987
else
997988
skip("kill_connection_from_server unsupported")
998989
end

0 commit comments

Comments
 (0)