Remove usage of OpenStruct

Author: fatkodima

.rubocop.yml

@@ -316,6 +316,9 @@ Style/RedundantCondition:
 Style/RedundantDoubleSplatHashBraces:
   Enabled: true
 
+Style/OpenStructUse:
+  Enabled: true
+
 Style/ArrayIntersect:
   Enabled: true
 
@@ -355,9 +358,6 @@ Performance/DeletePrefix:
 Performance/DeleteSuffix:
   Enabled: true
 
-Performance/OpenStruct:
-  Enabled: true
-
 Performance/InefficientHashSearch:
   Enabled: true
 

Gemfile

@@ -38,9 +38,6 @@ gem "cgi", ">= 0.3.6", require: false
 
 gem "prism"
 
-# Became a bundled gem in Ruby 3.5
-gem "ostruct"
-
 group :lint do
   gem "syntax_tree", "6.1.1", require: false
 end

Gemfile.lock

@@ -368,7 +368,6 @@ GEM
     nokogiri (1.16.0-x86_64-linux)
       racc (~> 1.4)
     os (1.1.4)
-    ostruct (0.6.0)
     parallel (1.24.0)
     parser (3.2.2.4)
       ast (~> 2.4.1)
@@ -624,7 +623,6 @@ DEPENDENCIES
   msgpack (>= 1.7.0)
   mysql2 (~> 0.5)
   nokogiri (>= 1.8.1, != 1.11.0)
-  ostruct
   pg (~> 1.3)
   prism
   propshaft (>= 0.1.7)

actionmailer/test/url_test.rb

@@ -2,7 +2,6 @@
 
 require "abstract_unit"
 require "action_controller"
-require "ostruct"
 
 class WelcomeController < ActionController::Base
 end
@@ -42,7 +41,7 @@ def exercise_url_for(options)
 class ActionMailerUrlTest < ActionMailer::TestCase
   class DummyModel
     def self.model_name
-      OpenStruct.new(route_key: "dummy_model")
+      Struct.new(:route_key, :name).new("dummy_model", nil)
     end
 
     def persisted?

actionpack/test/controller/http_token_authentication_test.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require "ostruct"
 require "abstract_unit"
 
 class HttpTokenAuthenticationTest < ActionController::TestCase
@@ -240,7 +239,7 @@ def sample_request_without_token_key(token)
     end
 
     def mock_authorization_request(authorization)
-      OpenStruct.new(authorization: authorization)
+      Struct.new(:authorization).new(authorization)
     end
 
     def encode_credentials(token, options = {})

actionview/test/lib/controller/fake_models.rb

@@ -207,7 +207,7 @@ class Plane
 
   class << self
     def model_name
-      OpenStruct.new param_key: "airplane"
+      Struct.new(:param_key).new("airplane")
     end
   end
 

actionview/test/template/controller_helper_test.rb

@@ -1,34 +1,35 @@
 # frozen_string_literal: true
 
 require "abstract_unit"
-require "ostruct"
 
 class ControllerHelperTest < ActionView::TestCase
   tests ActionView::Helpers::ControllerHelper
 
   class SpecializedFormBuilder < ActionView::Helpers::FormBuilder ; end
 
   def test_assign_controller_sets_default_form_builder
-    @controller = OpenStruct.new(default_form_builder: SpecializedFormBuilder)
+    @controller = Struct.new(:default_form_builder).new(SpecializedFormBuilder)
     assign_controller(@controller)
 
     assert_equal SpecializedFormBuilder, default_form_builder
   end
 
   def test_assign_controller_skips_default_form_builder
-    @controller = OpenStruct.new
+    @controller = Object.new
     assign_controller(@controller)
 
     assert_nil default_form_builder
   end
 
   def test_respond_to
-    @controller = OpenStruct.new
+    @controller = Object.new
     assign_controller(@controller)
     assert_not respond_to?(:params)
     assert respond_to?(:assign_controller)
 
-    @controller.params = {}
+    def @controller.params
+      {}
+    end
     assert respond_to?(:params)
     assert respond_to?(:assign_controller)
   end

actionview/test/template/form_helper_test.rb

@@ -2,7 +2,6 @@
 
 require "abstract_unit"
 require "controller/fake_models"
-require "ostruct"
 
 class FormHelperTest < ActionView::TestCase
   include RenderERBUtils
@@ -280,7 +279,7 @@ def test_label_with_locales_fallback_and_nested_attributes
   end
 
   def test_label_with_non_active_record_object
-    form_for(OpenStruct.new(name: "ok"), as: "person", url: "/an", html: { id: "create-person" }) do |f|
+    form_for(Struct.new(:name).new("ok"), as: "person", url: "/an", html: { id: "create-person" }) do |f|
       f.label(:name)
     end
 

actionview/test/template/record_identifier_test.rb

@@ -2,7 +2,6 @@
 
 require "abstract_unit"
 require "controller/fake_models"
-require "ostruct"
 
 class RecordIdentifierTest < ActiveSupport::TestCase
   include ActionView::RecordIdentifier

activejob/test/support/delayed_job/delayed/backend/test.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 # copied from https://github.com/collectiveidea/delayed_job/blob/master/spec/delayed/backend/test.rb
-require "ostruct"
 
 # An in-memory backend suitable only for testing. Tries to behave as if it were an ORM.
 module Delayed