Fix dropdown not opening

- Removes *potentially* unnecessary js from the code
- Closes a div in the index file

Author: keegankb93

guides/assets/javascripts/guides.js

@@ -79,13 +79,6 @@
     // pressing escape, which is the standard key to collapse expanded elements.
     var guidesMenuButton = document.getElementById("guides-menu-button");
 
-    // The link is now acting as a button (but still allows for open in new tab).
-    guidesMenuButton.setAttribute('role', 'button')
-    guidesMenuButton.setAttribute('aria-controls', guidesMenuButton.getAttribute('data-aria-controls'));
-    guidesMenuButton.setAttribute('aria-expanded', guidesMenuButton.getAttribute('data-aria-expanded'));
-    guidesMenuButton.removeAttribute('data-aria-controls');
-    guidesMenuButton.removeAttribute('data-aria-expanded');
-
     var guides = document.getElementById(
       guidesMenuButton.getAttribute("aria-controls")
     );

guides/source/layout.html.erb

@@ -78,7 +78,7 @@
         <ul class="nav">
           <li><a class="nav-item" id="home_nav" href="https://rubyonrails.org/">Home</a></li>
           <li class="guides-index guides-index-large">
-            <a href="index.html" id="guides-menu-button" data-aria-controls="guides" data-aria-expanded="false" class="guides-index-item nav-item">Guides Index</a>
+            <a href="index.html" id="guides-menu-button" role="button" aria-controls="guides" aria-expanded="false" class="guides-index-item nav-item">Guides Index</a>
             <div id="guides" class="clearfix" style="display: none;">
               <hr />
               <dl class="guides-section-container">
@@ -161,6 +161,7 @@
               documentation is very welcome on the <%= link_to 'official Ruby on Rails Forum', 'https://discuss.rubyonrails.org/c/rubyonrails-docs' %>.
             </p>
           </footer>
+        </div>
       </div>
     </article>
   </main>