Merge pull request rails#50251 from abeidahmed/has_secure_token-call-setter-method

[Fix rails#49874] `has_secure_token` calls the setter method on initialize

Author: kamipo

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Fix `has_secure_token` calls the setter method on initialize.
+
+    *Abeid Ahmed*
+
 *   When using a `DATABASE_URL`, allow for a configuration to map the protocol in the URL to a specific database
     adapter. This allows decoupling the adapter the application chooses to use from the database connection details
     set in the deployment environment.

activerecord/lib/active_record/secure_token.rb

@@ -53,7 +53,7 @@ def has_secure_token(attribute = :token, length: MINIMUM_TOKEN_LENGTH, on: Activ
         define_method("regenerate_#{attribute}") { update! attribute => self.class.generate_unique_secure_token(length: length) }
         set_callback on, on == :initialize ? :after : :before do
           if new_record? && !query_attribute(attribute)
-            write_attribute(attribute, self.class.generate_unique_secure_token(length: length))
+            send("#{attribute}=", self.class.generate_unique_secure_token(length: length))
           end
         end
       end

activerecord/test/cases/secure_token_test.rb

@@ -98,4 +98,22 @@ def test_token_on_callback
 
     assert_predicate user.token, :present?
   end
+
+  def test_token_calls_the_setter_method
+    model = Class.new(ActiveRecord::Base) do
+      self.table_name = "users"
+      has_secure_token on: :initialize
+
+      attr_accessor :modified_token
+
+      def token=(value)
+        super
+        self.modified_token = "#{value}_modified"
+      end
+    end
+
+    user = model.new
+
+    assert_equal "#{user.token}_modified", user.modified_token
+  end
 end