Remove deprecation warning when using :interval column is used in PostgreSQL database

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,15 @@
+*   Remove deprecation warning when using `:interval` column is used in PostgreSQL database.
+
+    Now, interval columns will return `ActiveSupport::Duration` objects instead of strings.
+
+    To keep the old behavior, you can add this line to your model:
+
+    ```ruby
+    attribute :column, :string
+    ```
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated support to YAML load `ActiveRecord::Base` instance in the Rails 4.2 and 4.1 formats.
 
     *Rafael Mendonça França*

activerecord/lib/active_record/model_schema.rb

@@ -571,7 +571,6 @@ def load_schema!
           @columns_hash.each do |name, column|
             type = connection.lookup_cast_type_from_column(column)
             type = _convert_type_from_options(type)
-            warn_if_deprecated_type(column)
             define_attribute(
               name,
               type,
@@ -630,32 +629,6 @@ def _convert_type_from_options(type)
             type
           end
         end
-
-        def warn_if_deprecated_type(column)
-          return if attributes_to_define_after_schema_loads.key?(column.name)
-          return unless column.respond_to?(:array?)
-
-          if column.array?
-            array_arguments = ", array: true"
-          else
-            array_arguments = ""
-          end
-
-          if column.sql_type.start_with?("interval")
-            precision_arguments = column.precision.presence && ", precision: #{column.precision}"
-            ActiveSupport::Deprecation.warn(<<~WARNING)
-              The behavior of the `:interval` type will be changing in Rails 7.0
-              to return an `ActiveSupport::Duration` object. If you'd like to keep
-              the old behavior, you can add this line to #{self.name} model:
-
-                attribute :#{column.name}, :string#{precision_arguments}#{array_arguments}
-
-              If you'd like the new behavior today, you can add this line:
-
-                attribute :#{column.name}, :interval#{precision_arguments}#{array_arguments}
-            WARNING
-          end
-        end
     end
   end
 end

activerecord/test/cases/adapters/postgresql/interval_test.rb

@@ -7,15 +7,9 @@ class PostgresqlIntervalTest < ActiveRecord::PostgreSQLTestCase
   include SchemaDumpingHelper
 
   class IntervalDataType < ActiveRecord::Base
-    attribute :maximum_term, :interval
-    attribute :minimum_term, :interval, precision: 3
-    attribute :default_term, :interval
-    attribute :all_terms,    :interval, array: true
-    attribute :legacy_term,  :string
+    attribute :legacy_term, :string
   end
 
-  class DeprecatedIntervalDataType < ActiveRecord::Base; end
-
   def setup
     @connection = ActiveRecord::Base.connection
     @connection.transaction do
@@ -26,21 +20,17 @@ def setup
         t.interval "all_terms", array: true
         t.interval "legacy_term"
       end
-      @connection.create_table("deprecated_interval_data_types") do |t|
-        t.interval "duration"
-      end
     end
     @column_max = IntervalDataType.columns_hash["maximum_term"]
     @column_min = IntervalDataType.columns_hash["minimum_term"]
     assert(@column_max.is_a?(ActiveRecord::ConnectionAdapters::PostgreSQLColumn))
     assert(@column_min.is_a?(ActiveRecord::ConnectionAdapters::PostgreSQLColumn))
     assert_nil @column_max.precision
-    assert_equal 3,   @column_min.precision
+    assert_equal 3, @column_min.precision
   end
 
   teardown do
     @connection.execute "DROP TABLE IF EXISTS interval_data_types"
-    @connection.execute "DROP TABLE IF EXISTS deprecated_interval_data_types"
   end
 
   def test_column
@@ -94,12 +84,6 @@ def test_average_interval_type
     assert_instance_of ActiveSupport::Duration, value
   end
 
-  def test_deprecated_legacy_type
-    assert_deprecated do
-      DeprecatedIntervalDataType.new
-    end
-  end
-
   def test_schema_dump_with_default_value
     output = dump_table_schema "interval_data_types"
     assert_match %r{t\.interval "default_term", default: "P3Y"}, output

guides/source/7_0_release_notes.md

@@ -106,6 +106,16 @@ Please refer to the [Changelog][active-record] for detailed changes.
 
 *   Remove deprecated support to YAML load `ActiveRecord::Base` instance in the Rails 4.2 and 4.1 formats.
 
+*   Remove deprecation warning when using `:interval` column is used in PostgreSQL database.
+
+    Now, interval columns will return `ActiveSupport::Duration` objects instead of strings.
+
+    To keep the old behavior, you can add this line to your model:
+
+    ```ruby
+    attribute :column, :string
+    ```
+
 ### Deprecations
 
 ### Notable changes