Skip to content

Commit 0c93291

Browse files
committed
Pin minitest version to 5.21
Managed to reproduce CI failure at https://buildkite.com/rails/rails-nightly/builds/133#018d7bb8-8a32-4978-8e36-d7cb9b067813/1196-1204 . It would also reproduce against the released versions of Ruby because this is triggered by minitest v5.22.0 change. minitest/minitest@ebb468c To avoid all of railties CI failures, pin minitest version to 5.21 tentatively. * Steps to reproduce ```ruby git clone https://github.com/rails/rails cd rails rm Gemfile.lock bundle install cd railties bin/test test/application/test_runner_test.rb -n test_system_tests_are_not_run_with_the_default_test_command ``` * Expected behavior It should pass. * Actual behavior ```ruby $ bin/test test/application/test_runner_test.rb -n test_system_tests_are_not_run_with_the_default_test_command Run options: -n test_system_tests_are_not_run_with_the_default_test_command --seed 14574 F Failure: ApplicationTests::TestRunnerTest#test_system_tests_are_not_run_with_the_default_test_command [test/application/test_runner_test.rb:1191]: Expected /0\ runs,\ 0\ assertions,\ 0\ failures,\ 0\ errors,\ 0\ skips/ to match "Nothing ran for filter: \nRunning 0 tests in a single process (parallelization threshold is 50)\nRun options: --seed 45713\n\n# Running:\n\n". bin/test test/application/test_runner_test.rb:1179 Finished in 9.982314s, 0.1002 runs/s, 0.2004 assertions/s. 1 runs, 2 assertions, 1 failures, 0 errors, 0 skips $ ```
1 parent f14401a commit 0c93291

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
source "https://rubygems.org"
44
gemspec
55

6-
gem "minitest", ">= 5.15.0"
6+
gem "minitest", ">= 5.15.0", "< 5.22.0"
77

88
# We need a newish Rake since Active Job sets its test tasks' descriptions.
99
gem "rake", ">= 13"

Gemfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ PATH
9393
connection_pool (>= 2.2.5)
9494
drb
9595
i18n (>= 1.6, < 2)
96-
minitest (>= 5.1)
96+
minitest (>= 5.1, < 5.22.0)
9797
tzinfo (~> 2.0, >= 2.0.5)
9898
rails (7.2.0.alpha)
9999
actioncable (= 7.2.0.alpha)
@@ -618,7 +618,7 @@ DEPENDENCIES
618618
libxml-ruby
619619
listen (~> 3.3)
620620
mdl (!= 0.13.0)
621-
minitest (>= 5.15.0)
621+
minitest (>= 5.15.0, < 5.22.0)
622622
minitest-bisect
623623
minitest-ci
624624
minitest-retry

activesupport/activesupport.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Gem::Specification.new do |s|
3838
s.add_dependency "tzinfo", "~> 2.0", ">= 2.0.5"
3939
s.add_dependency "concurrent-ruby", "~> 1.0", ">= 1.0.2"
4040
s.add_dependency "connection_pool", ">= 2.2.5"
41-
s.add_dependency "minitest", ">= 5.1"
41+
s.add_dependency "minitest", ">= 5.1", "< 5.22.0"
4242
s.add_dependency "base64"
4343
s.add_dependency "drb"
4444
s.add_dependency "bigdecimal"

0 commit comments

Comments
 (0)