Simplify condition checks

kamipo · kamipo · commit 0f591639b864 · 2025-06-13T18:21:27.000+09:00
diff --git a/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb b/activerecord/lib/active_record/connection_adapters/sqlite3/database_statements.rb
@@ -104,7 +104,7 @@ def perform_query(raw_connection, sql, binds, type_casted_binds, prepare:, notif
                 result = if stmt.column_count.zero? # No return
                   stmt.step
 
-                  affected_rows = if (raw_connection.total_changes - total_changes_before_query) > 0
+                  affected_rows = if raw_connection.total_changes > total_changes_before_query
                     raw_connection.changes
                   else
                     0
@@ -114,7 +114,7 @@ def perform_query(raw_connection, sql, binds, type_casted_binds, prepare:, notif
                 else
                   rows = stmt.to_a
 
-                  affected_rows = if (raw_connection.total_changes - total_changes_before_query) > 0
+                  affected_rows = if raw_connection.total_changes > total_changes_before_query
                     raw_connection.changes
                   else
                     0

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ def perform_query(raw_connection, sql, binds, type_casted_binds, prepare:, notif`
`104`	`104`	`result = if stmt.column_count.zero? # No return`
`105`	`105`	`stmt.step`
`106`	`106`
`107`		`- affected_rows = if (raw_connection.total_changes - total_changes_before_query) > 0`
	`107`	`+ affected_rows = if raw_connection.total_changes > total_changes_before_query`
`108`	`108`	`raw_connection.changes`
`109`	`109`	`else`
`110`	`110`	`0`
`@@ -114,7 +114,7 @@ def perform_query(raw_connection, sql, binds, type_casted_binds, prepare:, notif`
`114`	`114`	`else`
`115`	`115`	`rows = stmt.to_a`
`116`	`116`
`117`		`- affected_rows = if (raw_connection.total_changes - total_changes_before_query) > 0`
	`117`	`+ affected_rows = if raw_connection.total_changes > total_changes_before_query`
`118`	`118`	`raw_connection.changes`
`119`	`119`	`else`
`120`	`120`	`0`