Merge pull request rails#49236 from shouichi/enable-literal-as-actual-argument

Enable Minitest/LiteralAsActualArgument

Author: jonathanhefner

.rubocop.yml

@@ -350,6 +350,9 @@ Minitest/AssertRaisesWithRegexpArgument:
 Minitest/AssertWithExpectedArgument:
   Enabled: true
 
+Minitest/LiteralAsActualArgument:
+  Enabled: true
+
 Minitest/SkipEnsure:
   Enabled: true
 

actionmailer/test/base_test.rb

@@ -832,8 +832,8 @@ def self.previewing_email(mail); end
   end
 
   test "proc default values can have arity of 1 where arg is a mailer instance" do
-    assert_equal(ProcMailer.welcome["X-Lambda-Arity-1-arg"].to_s, "complex_value")
-    assert_equal(ProcMailer.welcome["X-Lambda-Arity-1-self"].to_s, "complex_value")
+    assert_equal("complex_value", ProcMailer.welcome["X-Lambda-Arity-1-arg"].to_s)
+    assert_equal("complex_value", ProcMailer.welcome["X-Lambda-Arity-1-self"].to_s)
   end
 
   test "proc default values with fixed arity of 0 can be called" do

actionpack/test/controller/parameters/mutators_test.rb

@@ -181,7 +181,7 @@ class ParametersMutatorsTest < ActiveSupport::TestCase
     params = ActionController::Parameters.new(name: "Alex", age: "40", location: "Beijing")
     params.permit!
     params_hash = params.to_h { |key, value| [:"#{key}_modified", value] }
-    assert_equal params_hash.keys, %w(name_modified age_modified location_modified)
+    assert_equal %w(name_modified age_modified location_modified), params_hash.keys
   end
   # rubocop:enable Style/HashTransformKeys
 
@@ -190,7 +190,7 @@ class ParametersMutatorsTest < ActiveSupport::TestCase
     params = ActionController::Parameters.new(name: "Alex", age: "40", location: "Beijing")
     params.permit!
     params_hash = params.to_h { |key, value| [key, value.is_a?(String) ? "#{value}_modified" : value] }
-    assert_equal params_hash.values, %w(Alex_modified 40_modified Beijing_modified)
+    assert_equal %w(Alex_modified 40_modified Beijing_modified), params_hash.values
   end
   # rubocop:enable Style/HashTransformValues
 

actionpack/test/controller/routing_test.rb

@@ -1694,7 +1694,7 @@ def test_route_with_subdomain_and_constraints_must_receive_params
     end
     assert_equal({ controller: "pages", action: "show", name: "mypage" },
       set.recognize_path("http://subdomain.example.org/page/mypage"))
-    assert_equal(name_param, "mypage")
+    assert_equal("mypage", name_param)
   end
 
   def test_route_requirement_recognize_with_ignore_case

actionpack/test/controller/test_case_test.rb

@@ -259,7 +259,7 @@ def to_param
 
     post :test_params, params: { foo: klass.new }
 
-    assert_equal JSON.parse(@response.body)["foo"], "bar"
+    assert_equal "bar", JSON.parse(@response.body)["foo"]
   end
 
   def test_body_stream
@@ -1146,7 +1146,7 @@ class BarControllerTest < ActionController::TestCase
 
     def test_engine_controller_route
       get :index
-      assert_equal @response.body, "bar"
+      assert_equal "bar", @response.body
     end
   end
 
@@ -1159,7 +1159,7 @@ def setup
 
     def test_engine_controller_route
       get :index
-      assert_equal @response.body, "bar"
+      assert_equal "bar", @response.body
     end
   end
 end

actionpack/test/dispatch/mime_type_test.rb

@@ -161,8 +161,8 @@ class MimeTypeTest < ActiveSupport::TestCase
   end
 
   test "type should be equal to symbol" do
-    assert_equal Mime[:html], "application/xhtml+xml"
-    assert_equal Mime[:html], :html
+    assert_operator Mime[:html], :==, "application/xhtml+xml"
+    assert_operator Mime[:html], :==, :html
   end
 
   test "type convenience methods" do

actionpack/test/dispatch/response_test.rb

@@ -402,7 +402,7 @@ def test_only_set_charset_still_defaults_to_text_html
   test "[response.to_a].flatten does not recurse infinitely" do
     Timeout.timeout(1) do # use a timeout to prevent it stalling indefinitely
       status, headers, body = [@response.to_a].flatten
-      assert_equal status, 200
+      assert_equal 200, status
       assert_equal headers, @response.headers
       assert_nil body
     end

actionpack/test/dispatch/test_response_test.rb

@@ -37,7 +37,7 @@ def assert_response_code_range(range, predicate)
       </html>
     HTML
     assert_kind_of(Nokogiri::XML::Document, response.parsed_body)
-    assert_equal(response.parsed_body.at_xpath("/html/body/div").text, "Content")
+    assert_equal("Content", response.parsed_body.at_xpath("/html/body/div").text)
   end
 
   if RUBY_VERSION >= "3.1"

actionview/test/actionpack/controller/render_test.rb

@@ -1497,7 +1497,7 @@ def test_template_annotations_do_not_render_for_non_html_format
     end
 
     assert_not_includes @response.body, "BEGIN"
-    assert_equal @response.body.split("\n").length, 1
+    assert_equal 1, @response.body.split("\n").length
   end
 
   def test_line_offset_with_annotations_enabled

actionview/test/template/render_test.rb

@@ -151,7 +151,7 @@ def test_render_raw_is_html_safe_and_does_not_escape_output
     buffer = ActiveSupport::SafeBuffer.new
     buffer << @view.render(template: "plain_text")
     assert_equal true, buffer.html_safe?
-    assert_equal buffer, "<%= hello_world %>\n"
+    assert_equal "<%= hello_world %>\n", buffer
   end
 
   def test_render_ruby_template_with_handlers