Raise ArgumentError on empty query_constraints configuration

Author: nvasilevski

activerecord/lib/active_record/persistence.rb

@@ -485,6 +485,8 @@ def update!(id = :all, attributes)
       #   developer.reload
       #   # => SELECT "developers".* FROM "developers" WHERE "developers"."company_id" = 1 AND "developers"."id" = 1 LIMIT 1
       def query_constraints(*columns_list)
+        raise ArgumentError, "You must specify at least one column to be used in querying" if columns_list.empty?
+
         @_query_constraints_list = columns_list.map(&:to_s)
       end
 

activerecord/test/cases/persistence_test.rb

@@ -1476,4 +1476,13 @@ def assert_uses_query_constraints_on_reload(object, columns)
       assert_match(/WHERE .*#{column}/, sql)
     end
   end
+
+  def test_query_constraints_raises_an_error_when_no_columns_provided
+    assert_raises(ArgumentError) do
+      Class.new(ActiveRecord::Base) do
+        self.table_name = "topics"
+        query_constraints
+      end
+    end
+  end
 end