Merge pull request rails#45697 from adrianna-chang-shopify/ac-change-column-default-mysql

Use SET DEFAULT when changing a column default in MySQL

Author: byroot

activerecord/lib/active_record/connection_adapters.rb

@@ -18,6 +18,7 @@ module ConnectionAdapters
       autoload :IndexDefinition
       autoload :ColumnDefinition
       autoload :ChangeColumnDefinition
+      autoload :ChangeColumnDefaultDefinition
       autoload :ForeignKeyDefinition
       autoload :CheckConstraintDefinition
       autoload :TableDefinition

activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb

@@ -94,6 +94,8 @@ def aliased_types(name, fallback)
 
     ChangeColumnDefinition = Struct.new(:column, :name, :ddl) # :nodoc:
 
+    ChangeColumnDefaultDefinition = Struct.new(:column, :default, :ddl) # :nodoc:
+
     CreateIndexDefinition = Struct.new(:index, :algorithm, :if_not_exists, :ddl) # :nodoc:
 
     PrimaryKeyDefinition = Struct.new(:name) # :nodoc:

activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb

@@ -1692,6 +1692,14 @@ def add_column_for_alter(table_name, column_name, type, **options)
           schema_creation.accept(AddColumnDefinition.new(cd))
         end
 
+        def change_column_default_for_alter(table_name, column_name, default_or_changes)
+          column = column_for(table_name, column_name)
+          return unless column
+
+          default = extract_new_default_value(default_or_changes)
+          schema_creation.accept(ChangeColumnDefaultDefinition.new(column, default))
+        end
+
         def rename_column_sql(table_name, column_name, new_column_name)
           "RENAME COLUMN #{quote_column_name(column_name)} TO #{quote_column_name(new_column_name)}"
         end

activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb

@@ -347,8 +347,7 @@ def rename_index(table_name, old_name, new_name)
       end
 
       def change_column_default(table_name, column_name, default_or_changes) # :nodoc:
-        default = extract_new_default_value(default_or_changes)
-        change_column table_name, column_name, nil, default: default
+        execute "ALTER TABLE #{quote_table_name(table_name)} #{change_column_default_for_alter(table_name, column_name, default_or_changes)}"
       end
 
       def change_column_null(table_name, column_name, null, default = nil) # :nodoc:

activerecord/lib/active_record/connection_adapters/mysql/schema_creation.rb

@@ -24,6 +24,16 @@ def visit_ChangeColumnDefinition(o)
             o.ddl = add_column_position!(change_column_sql, column_options(o.column))
           end
 
+          def visit_ChangeColumnDefaultDefinition(o)
+            sql = +"ALTER COLUMN #{quote_column_name(o.column.name)} SET DEFAULT "
+            if o.default.nil?
+              sql << "NULL"
+            else
+              sql << quote_default_expression(o.default, o.column)
+            end
+            o.ddl = sql
+          end
+
           def visit_CreateIndexDefinition(o)
             sql = visit_IndexDefinition(o.index, true)
             sql << " #{o.algorithm}" if o.algorithm

activerecord/lib/active_record/connection_adapters/postgresql/schema_creation.rb

@@ -87,6 +87,16 @@ def visit_ChangeColumnDefinition(o)
             o.ddl = change_column_sql
           end
 
+          def visit_ChangeColumnDefaultDefinition(o)
+            sql = +"ALTER COLUMN #{quote_column_name(o.column.name)} "
+            if o.default.nil?
+              sql << "DROP DEFAULT"
+            else
+              sql << "SET DEFAULT #{quote_default_expression(o.default, o.column)}"
+            end
+            o.ddl = sql
+          end
+
           def add_column_options!(sql, options)
             if options[:collation]
               sql << " COLLATE \"#{options[:collation]}\""

activerecord/lib/active_record/connection_adapters/postgresql/schema_statements.rb

@@ -855,21 +855,6 @@ def change_column_for_alter(table_name, column_name, type, **options)
             sqls
           end
 
-          def change_column_default_for_alter(table_name, column_name, default_or_changes)
-            column = column_for(table_name, column_name)
-            return unless column
-
-            default = extract_new_default_value(default_or_changes)
-            alter_column_query = "ALTER COLUMN #{quote_column_name(column_name)} %s"
-            if default.nil?
-              # <tt>DEFAULT NULL</tt> results in the same behavior as <tt>DROP DEFAULT</tt>. However, PostgreSQL will
-              # cast the default to the columns type, which leaves us with a default like "default NULL::character varying".
-              alter_column_query % "DROP DEFAULT"
-            else
-              alter_column_query % "SET DEFAULT #{quote_default_expression(default, column)}"
-            end
-          end
-
           def change_column_null_for_alter(table_name, column_name, null, default = nil)
             if default.nil?
               "ALTER COLUMN #{quote_column_name(column_name)} #{null ? 'DROP' : 'SET'} NOT NULL"