Merge pull request rails#43705 from gmcgibbon/fixes_for_43294

Fix metadata assertions in direct upload tests

Author: gmcgibbon

activestorage/test/controllers/direct_uploads_controller_test.rb

@@ -23,7 +23,7 @@ class ActiveStorage::S3DirectUploadsControllerTest < ActionDispatch::Integration
         "my_key_2": "my_value_2",
         "platform": "my_platform",
         "library_ID": "12345",
-        custom: {
+        "custom": {
           "my_key_3": "my_value_3"
         }
       }
@@ -38,7 +38,7 @@ class ActiveStorage::S3DirectUploadsControllerTest < ActionDispatch::Integration
         assert_equal "hello.txt", details["filename"]
         assert_equal 6, details["byte_size"]
         assert_equal checksum, details["checksum"]
-        assert_equal metadata, details["metadata"].transform_keys(&:to_sym)
+        assert_equal metadata, details["metadata"].deep_transform_keys(&:to_sym)
         assert_equal "text/plain", details["content_type"]
         assert_match SERVICE_CONFIGURATIONS[:s3][:bucket], details["direct_upload"]["url"]
         assert_match(/s3(-[-a-z0-9]+)?\.(\S+)?amazonaws\.com/, details["direct_upload"]["url"])
@@ -71,7 +71,7 @@ class ActiveStorage::GCSDirectUploadsControllerTest < ActionDispatch::Integratio
         "my_key_2": "my_value_2",
         "platform": "my_platform",
         "library_ID": "12345",
-        custom: {
+        "custom": {
           "my_key_3": "my_value_3"
         }
       }
@@ -86,7 +86,7 @@ class ActiveStorage::GCSDirectUploadsControllerTest < ActionDispatch::Integratio
         assert_equal "hello.txt", details["filename"]
         assert_equal 6, details["byte_size"]
         assert_equal checksum, details["checksum"]
-        assert_equal metadata, details["metadata"].transform_keys(&:to_sym)
+        assert_equal metadata, details["metadata"].deep_transform_keys(&:to_sym)
         assert_equal "text/plain", details["content_type"]
         assert_match %r{storage\.googleapis\.com/#{@config[:bucket]}}, details["direct_upload"]["url"]
         assert_equal({ "Content-MD5" => checksum, "Content-Disposition" => "inline; filename=\"hello.txt\"; filename*=UTF-8''hello.txt", "x-goog-meta-my_key_3" => "my_value_3" }, details["direct_upload"]["headers"])
@@ -130,7 +130,7 @@ class ActiveStorage::AzureStorageDirectUploadsControllerTest < ActionDispatch::I
         assert_equal "hello.txt", details["filename"]
         assert_equal 6, details["byte_size"]
         assert_equal checksum, details["checksum"]
-        assert_equal metadata, details["metadata"].transform_keys(&:to_sym)
+        assert_equal metadata, details["metadata"].deep_transform_keys(&:to_sym)
         assert_equal "text/plain", details["content_type"]
         assert_match %r{#{@config[:storage_account_name]}\.blob\.core\.windows\.net/#{@config[:container]}}, details["direct_upload"]["url"]
         assert_equal({ "Content-Type" => "text/plain", "Content-MD5" => checksum, "x-ms-blob-content-disposition" => "inline; filename=\"hello.txt\"; filename*=UTF-8''hello.txt", "x-ms-blob-type" => "BlockBlob" }, details["direct_upload"]["headers"])
@@ -162,7 +162,7 @@ class ActiveStorage::DiskDirectUploadsControllerTest < ActionDispatch::Integrati
       assert_equal "hello.txt", details["filename"]
       assert_equal 6, details["byte_size"]
       assert_equal checksum, details["checksum"]
-      assert_equal metadata, details["metadata"].transform_keys(&:to_sym)
+      assert_equal metadata, details["metadata"].deep_transform_keys(&:to_sym)
       assert_equal "text/plain", details["content_type"]
       assert_match(/rails\/active_storage\/disk/, details["direct_upload"]["url"])
       assert_equal({ "Content-Type" => "text/plain" }, details["direct_upload"]["headers"])
@@ -212,7 +212,7 @@ class ActiveStorage::DiskDirectUploadsControllerTest < ActionDispatch::Integrati
       assert_equal "hello.txt", details["filename"]
       assert_equal 6, details["byte_size"]
       assert_equal checksum, details["checksum"]
-      assert_equal metadata, details["metadata"].transform_keys(&:to_sym)
+      assert_equal metadata, details["metadata"].deep_transform_keys(&:to_sym)
       assert_equal "text/plain", details["content_type"]
       assert_match(/rails\/active_storage\/disk/, details["direct_upload"]["url"])
       assert_equal({ "Content-Type" => "text/plain" }, details["direct_upload"]["headers"])