Merge pull request rails#44625 from jonathanhefner/serialize_cast_value

Avoid double type cast when serializing attributes

Author: jonathanhefner

activemodel/lib/active_model/attribute.rb

@@ -179,6 +179,10 @@ def type_cast(value)
           type.cast(value)
         end
 
+        def value_for_database
+          Type::SerializeCastValue.serialize(type, value)
+        end
+
         def came_from_user?
           !type.value_constructed_by_mass_assignment?(value_before_type_cast)
         end

activemodel/lib/active_model/type.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "active_model/type/helpers"
+require "active_model/type/serialize_cast_value"
 require "active_model/type/value"
 
 require "active_model/type/big_integer"

activemodel/lib/active_model/type/big_integer.rb

@@ -21,6 +21,12 @@ module Type
     # All casting and serialization are performed in the same way as the
     # standard ActiveModel::Type::Integer type.
     class BigInteger < Integer
+      include SerializeCastValue
+
+      def serialize_cast_value(value) # :nodoc:
+        value
+      end
+
       private
         def max_value
           ::Float::INFINITY

activemodel/lib/active_model/type/boolean.rb

@@ -10,6 +10,8 @@ module Type
     # - Empty strings are coerced to +nil+.
     # - All other values will be coerced to +true+.
     class Boolean < Value
+      include SerializeCastValue
+
       FALSE_VALUES = [
         false, 0,
         "0", :"0",

activemodel/lib/active_model/type/date.rb

@@ -22,6 +22,7 @@ module Type
     # String values are parsed using the ISO 8601 date format. Any other values
     # are cast using their +to_date+ method, if it exists.
     class Date < Value
+      include SerializeCastValue
       include Helpers::Timezone
       include Helpers::AcceptsMultiparameterTime.new
 

activemodel/lib/active_model/type/date_time.rb

@@ -38,6 +38,7 @@ module Type
     #     attribute :start, :datetime, precision: 4
     #   end
     class DateTime < Value
+      include SerializeCastValue
       include Helpers::Timezone
       include Helpers::TimeValue
       include Helpers::AcceptsMultiparameterTime.new(
@@ -48,6 +49,8 @@ def type
         :datetime
       end
 
+      alias :serialize_cast_value :serialize_time_value # :nodoc:
+
       private
         def cast_value(value)
           return apply_seconds_precision(value) unless value.is_a?(::String)

activemodel/lib/active_model/type/decimal.rb

@@ -32,6 +32,7 @@ module Type
     #     attribute :weight, :decimal, precision: 24
     #   end
     class Decimal < Value
+      include SerializeCastValue
       include Helpers::Numeric
       BIGDECIMAL_PRECISION = 18
 

activemodel/lib/active_model/type/float.rb

@@ -26,6 +26,7 @@ module Type
     # - <tt>"-Infinity"</tt> is cast to <tt>-Float::INFINITY</tt>.
     # - <tt>"NaN"</tt> is cast to <tt>Float::NAN</tt>.
     class Float < Value
+      include SerializeCastValue
       include Helpers::Numeric
 
       def type

activemodel/lib/active_model/type/helpers/time_value.rb

@@ -20,6 +20,7 @@ def serialize(value)
 
           value
         end
+        alias :serialize_time_value :serialize
 
         def apply_seconds_precision(value)
           return value unless precision && value.respond_to?(:nsec)

activemodel/lib/active_model/type/immutable_string.rb

@@ -33,6 +33,8 @@ module Type
     #
     #   person.active # => "aye"
     class ImmutableString < Value
+      include SerializeCastValue
+
       def initialize(**args)
         @true  = -(args.delete(:true)&.to_s  || "t")
         @false = -(args.delete(:false)&.to_s || "f")