Use limit in #sole, not first.

kivikakk · byroot · commit 1c3b8d93b64e · 2024-12-18T08:58:24.000+01:00
`first` forces an ordering even if we've deliberately removed any orderings on
the underlying scope. Given the nature of `#sole`, this change doesn't affect
the results, but does allow the user to omit orderings where it would pessimise
the query (as we've discovered on a large site).
diff --git a/activerecord/lib/active_record/relation/finder_methods.rb b/activerecord/lib/active_record/relation/finder_methods.rb
@@ -141,7 +141,7 @@ def take!
     #
     #   Product.where(["price = %?", price]).sole
     def sole
-      found, undesired = first(2)
+      found, undesired = limit(2)
 
       if found.nil?
         raise_record_not_found_exception!

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ def take!`
`141`	`141`	`#`
`142`	`142`	`# Product.where(["price = %?", price]).sole`
`143`	`143`	`def sole`
`144`		`- found, undesired = first(2)`
	`144`	`+ found, undesired = limit(2)`
`145`	`145`
`146`	`146`	`if found.nil?`
`147`	`147`	`raise_record_not_found_exception!`