Fix response_finished Executor test for Rack HEAD

We're interested in adding more validation to response_finished
callbacks, in this case making sure the environment is a valid rack
environment.

This commit addresses that change by passing the real env given to the
middleware to the callback as well (since its already a valid env and
the server will end up doing this kind of thing).

Author: skipkayhil

actionpack/test/dispatch/executor_test.rb

@@ -174,13 +174,15 @@ def test_complete_callbacks_are_called_on_rack_response_finished
     completed = false
     executor.to_complete { completed = true }
 
-    env = { "rack.response_finished" => [] }
+    env = Rack::MockRequest.env_for
+    env["rack.response_finished"] = []
+
     call_and_return_body(env)
 
     assert_not completed
 
     assert_equal 1, env["rack.response_finished"].size
-    env["rack.response_finished"].first.call({}, 200, {}, nil)
+    env["rack.response_finished"].first.call(env, 200, {}, nil)
 
     assert completed
   end
@@ -189,7 +191,8 @@ def test_complete_callbacks_are_called_once_on_rack_response_finished_when_excep
     completed_count = 0
     executor.to_complete { completed_count += 1 }
 
-    env = { "rack.response_finished" => [] }
+    env = Rack::MockRequest.env_for
+    env["rack.response_finished"] = []
 
     begin
       call_and_return_body(env) do
@@ -199,15 +202,14 @@ def test_complete_callbacks_are_called_once_on_rack_response_finished_when_excep
     end
 
     assert_equal 1, env["rack.response_finished"].size
-    env["rack.response_finished"].first.call({}, 200, {}, nil)
+    env["rack.response_finished"].first.call(env, 200, {}, nil)
 
     assert_equal 1, completed_count
   end
 
   private
-    def call_and_return_body(env = {}, &block)
+    def call_and_return_body(env = Rack::MockRequest.env_for, &block)
       app = block || proc { [200, {}, []] }
-      env = Rack::MockRequest.env_for("", env)
       _, _, body = middleware(app).call(env)
       body
     end