[rail_inspector] Fix recognizing self. config

It previously would only find `self.` configs as
`Rails.application.config`, but `Rails.configuration` should also be
found.

Author: skipkayhil

tools/rail_inspector/lib/rail_inspector/configuring/check/framework_defaults.rb

@@ -10,35 +10,33 @@ class FrameworkDefaults
         class NewFrameworkDefaultsFile
           attr_reader :checker, :visitor
 
-          def initialize(checker, visitor)
+          # Defaults are strings like:
+          #   self.yjit
+          #   action_controller.escape_json_responses
+          def initialize(checker, defaults, file_content)
             @checker = checker
-            @visitor = visitor
+            @defaults = defaults
+            @file_content = file_content
           end
 
           def check
-            visitor.config_map[checker.rails_version].each_key do |config|
-              app_config = config.gsub(/^self/, "config")
+            @defaults.each do |config|
+              if config.start_with? "self"
+                next if @file_content.include? config.gsub(/^self/, "config")
+                next if @file_content.include? config.gsub(/^self/, "configuration")
+              end
 
-              next if defaults_file_content.include? app_config
+              next if @file_content.include? config
 
               next if config == "self.yjit"
 
-              add_error(config)
-            end
-          end
-
-          private
-            def add_error(config)
               checker.errors << <<~MESSAGE
-              #{new_framework_defaults_path}
-              Missing: #{config}
+                #{checker.files.new_framework_defaults}: Missing new default
+                #{config}
 
               MESSAGE
             end
-
-            def defaults_file_content
-              @defaults_file_content ||= checker.files.new_framework_defaults.read
-            end
+          end
         end
 
         attr_reader :checker
@@ -50,7 +48,11 @@ def initialize(checker)
         def check
           header, *defaults_by_version = documented_defaults
 
-          NewFrameworkDefaultsFile.new(checker, visitor).check
+          NewFrameworkDefaultsFile.new(
+            checker,
+            visitor.config_map[checker.rails_version].keys,
+            checker.files.new_framework_defaults.read
+          ).check
 
           checker.doc.versioned_defaults =
             header +

tools/rail_inspector/test/rail_inspector/configuring/check/framework_defaults_test.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require "test_helper"
+require "rail_inspector/configuring"
+
+class TestFrameworkDefaults < ActiveSupport::TestCase
+  def test_identifies_self_when_file_uses_config
+    defaults = ["self.log_file_size"]
+
+    check(defaults, <<~FILE).check
+    ###
+    # You must apply this in config/application.rb
+    # config.log_file_size = 100 * 1024 * 1024
+    FILE
+
+    assert_empty checker.errors
+  end
+
+  def test_identifies_self_when_file_uses_configuration
+    defaults = ["self.log_file_size"]
+
+    check(defaults, <<~FILE).check
+    ###
+    # You must apply this in config/application.rb
+    # Rails.configuration.log_file_size = 100 * 1024 * 1024
+    FILE
+
+    assert_empty checker.errors
+  end
+
+  private
+    def check(defaults, file_content)
+      @check ||= RailInspector::Configuring::Check::FrameworkDefaults::NewFrameworkDefaultsFile.new(checker, defaults, file_content)
+    end
+
+    def checker
+      @checker ||= RailInspector::Configuring.new("../..")
+    end
+end