Avoid checking if internal objects respond to methods

We can just make sure all objects used in that method have the
same interface.

Author: rafaelfranca

activerecord/lib/active_record/connection_adapters/abstract/quoting.rb

@@ -147,7 +147,7 @@ def quote_default_expression(value, column) # :nodoc:
           value.call
         else
           # TODO: Remove fetch_cast_type and the need for connection after we release 8.1.
-          cast_type = column.respond_to?(:fetch_cast_type) ? column.fetch_cast_type(self) : lookup_cast_type(column.sql_type)
+          cast_type = column.fetch_cast_type(self)
           value = cast_type.serialize(value)
           quote(value)
         end

activerecord/lib/active_record/connection_adapters/abstract/schema_creation.rb

@@ -17,7 +17,7 @@ def accept(o)
         :options_include_default?, :supports_indexes_in_create?, :use_foreign_keys?,
         :quoted_columns_for_index, :supports_partial_index?, :supports_check_constraints?,
         :supports_index_include?, :supports_exclusion_constraints?, :supports_unique_constraints?,
-        :supports_nulls_not_distinct?,
+        :supports_nulls_not_distinct?, :lookup_cast_type,
         to: :@conn, private: true
 
       private
@@ -148,7 +148,7 @@ def column_options(o)
         end
 
         def add_column_options!(sql, options)
-          sql << " DEFAULT #{quote_default_expression(options[:default], options[:column])}" if options_include_default?(options)
+          sql << " DEFAULT #{quote_default_expression_for_column_definition(options[:default], options[:column])}" if options_include_default?(options)
           # must explicitly check for :null to allow change_column to work on migrations
           if options[:null] == false
             sql << " NOT NULL"
@@ -162,6 +162,11 @@ def add_column_options!(sql, options)
           sql
         end
 
+        def quote_default_expression_for_column_definition(default, column_definition)
+          column_definition.cast_type = lookup_cast_type(column_definition.sql_type)
+          quote_default_expression(default, column_definition)
+        end
+
         def to_sql(sql)
           sql = sql.to_sql if sql.respond_to?(:to_sql)
           sql

activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb

@@ -75,7 +75,7 @@ def concise_options(options)
     # are typically created by methods in TableDefinition, and added to the
     # +columns+ attribute of said TableDefinition object, in order to be used
     # for generating a number of table creation or table changing SQL statements.
-    ColumnDefinition = Struct.new(:name, :type, :options, :sql_type) do # :nodoc:
+    ColumnDefinition = Struct.new(:name, :type, :options, :sql_type, :cast_type) do # :nodoc:
       self::OPTION_NAMES = [
         :limit,
         :precision,
@@ -108,6 +108,10 @@ def #{option_name}=(value)
       def aliased_types(name, fallback)
         "timestamp" == name ? :datetime : fallback
       end
+
+      def fetch_cast_type(connection)
+        cast_type
+      end
     end
 
     AddColumnDefinition = Struct.new(:column) # :nodoc:

activerecord/lib/active_record/connection_adapters/postgresql/schema_creation.rb

@@ -99,7 +99,7 @@ def visit_ChangeColumnDefinition(o)
               if options[:default].nil?
                 change_column_sql << ", ALTER COLUMN #{quoted_column_name} DROP DEFAULT"
               else
-                quoted_default = quote_default_expression(options[:default], column)
+                quoted_default = quote_default_expression_for_column_definition(options[:default], column)
                 change_column_sql << ", ALTER COLUMN #{quoted_column_name} SET DEFAULT #{quoted_default}"
               end
             end