Remove deprecated support to type cast to database values ActiveRecord::Base objects

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove deprecated support to type cast to database values `ActiveRecord::Base` objects.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated support to quote `ActiveRecord::Base` objects.
 
     *Rafael Mendonça França*

activerecord/lib/active_record/connection_adapters/abstract/quoting.rb

@@ -16,14 +16,6 @@ def quote(value)
       # SQLite does not understand dates, so this method will convert a Date
       # to a String.
       def type_cast(value, column = nil)
-        if value.is_a?(Base)
-          ActiveSupport::Deprecation.warn(<<~MSG)
-            Passing an Active Record object to `type_cast` directly is deprecated
-            and will be no longer type casted as id value in Rails 7.0.
-          MSG
-          value = value.id_for_database
-        end
-
         if column
           ActiveSupport::Deprecation.warn(<<~MSG)
             Passing a column to `type_cast` is deprecated and will be removed in Rails 7.0.

activerecord/test/cases/quoting_test.rb

@@ -248,30 +248,5 @@ def test_type_cast_returns_frozen_value
         assert_predicate @connection.type_cast(false), :frozen?
       end
     end
-
-    if supports_datetime_with_precision?
-      class QuoteARBaseTest < ActiveRecord::TestCase
-        class DatetimePrimaryKey < ActiveRecord::Base
-        end
-
-        def setup
-          @time = ::Time.utc(2017, 2, 14, 12, 34, 56, 789999)
-          @connection = ActiveRecord::Base.connection
-          @connection.create_table :datetime_primary_keys, id: :datetime, precision: 3, force: true
-        end
-
-        def teardown
-          @connection.drop_table :datetime_primary_keys, if_exists: true
-        end
-
-        def test_type_cast_ar_object
-          value = DatetimePrimaryKey.new(id: @time)
-          expected = @connection.type_cast(value.id)
-          assert_deprecated do
-            assert_equal expected, @connection.type_cast(value)
-          end
-        end
-      end
-    end
   end
 end

guides/source/7_0_release_notes.md

@@ -120,6 +120,8 @@ Please refer to the [Changelog][active-record] for detailed changes.
 
 *   Remove deprecated support to quote `ActiveRecord::Base` objects.
 
+*   Remove deprecated support to type cast to database values `ActiveRecord::Base` objects.
+
 ### Deprecations
 
 ### Notable changes