Merge pull request rails#50297 from iamradioactive/handle_composite_foreign_keys

Fix stale state for composite foreign keys in belongs_to association

Author: eugeneius

activerecord/lib/active_record/associations/belongs_to_association.rb

@@ -162,7 +162,9 @@ def invertible_for?(record)
         end
 
         def stale_state
-          owner._read_attribute(reflection.foreign_key) { |n| owner.send(:missing_attribute, n, caller) }
+          Array(reflection.foreign_key).map do |fk|
+            owner._read_attribute(fk) { |n| owner.send(:missing_attribute, n, caller) }
+          end
         end
     end
   end

activerecord/test/cases/associations/belongs_to_associations_test.rb

@@ -31,6 +31,9 @@
 require "models/node"
 require "models/club"
 require "models/cpk"
+require "models/sharded/blog"
+require "models/sharded/blog_post"
+require "models/sharded/comment"
 
 class BelongsToAssociationsTest < ActiveRecord::TestCase
   fixtures :accounts, :companies, :developers, :projects, :topics,
@@ -400,6 +403,18 @@ def test_should_set_composite_foreign_key_on_association_when_key_changes_on_ass
     assert_equal 3, book.shop_id
   end
 
+  def test_should_reload_association_on_model_with_query_constraints_when_foreign_key_changes
+    blog = Sharded::Blog.create!
+    blog_post = Sharded::BlogPost.create!(blog: blog)
+    comment = Sharded::Comment.create!(blog: blog)
+
+    # Load the association once
+    comment.blog_post
+    comment.blog_post_id = blog_post.id
+
+    assert_equal blog_post, comment.blog_post
+  end
+
   def test_building_the_belonging_object_with_implicit_sti_base_class
     account = Account.new
     company = account.build_firm