Merge pull request rails#52496 from martin-mfv/improve-activestorage-filename-sanitized

Added new unsafe characters of Windows filename `", <, >, ?, *` to `ActiveStorage::Filename#sanitized`

Author: byroot

activestorage/CHANGELOG.md

@@ -1,3 +1,8 @@
+*   Improve `ActiveStorage::Filename#sanitized` method to handle special characters more effectively.
+    Replace the characters `"*?<>` with `-` if they exist in the Filename to match the Filename convention of Win OS.
+
+    *Luong Viet Dung(Martin)*
+
 *   Improve InvariableError, UnpreviewableError and UnrepresentableError message.
 
     Include Blob ID and content_type in the messages.
@@ -8,4 +13,5 @@
 
     *Nate Matykiewicz*
 
+
 Please check [7-2-stable](https://github.com/rails/rails/blob/7-2-stable/activestorage/CHANGELOG.md) for previous changes.

activestorage/app/models/active_storage/filename.rb

@@ -57,7 +57,7 @@ def extension_without_delimiter
   #
   # Characters considered unsafe for storage (e.g. \, $, and the RTL override character) are replaced with a dash.
   def sanitized
-    @filename.encode(Encoding::UTF_8, invalid: :replace, undef: :replace, replace: "�").strip.tr("\u{202E}%$|:;/\t\r\n\\", "-")
+    @filename.encode(Encoding::UTF_8, invalid: :replace, undef: :replace, replace: "�").strip.tr("\u{202E}%$|:;/<>?*\"\t\r\n\\", "-")
   end
 
   # Returns the sanitized version of the filename.

activestorage/test/models/filename_test.rb

@@ -22,7 +22,7 @@ class ActiveStorage::FilenameTest < ActiveSupport::TestCase
   end
 
   test "sanitize" do
-    "%$|:;/\t\r\n\\".each_char do |character|
+    "%$|:;/<>?*\"\t\r\n\\".each_char do |character|
       filename = ActiveStorage::Filename.new("foo#{character}bar.pdf")
       assert_equal "foo-bar.pdf", filename.sanitized
       assert_equal "foo-bar.pdf", filename.to_s