Skip to content

Commit 269037a

Browse files
authored
Merge pull request rails#44501 from ghousemohamed/fix-inconsistency-in-activemodel-testcases
Fixed inconsistencies in ActiveModel test cases
2 parents eaccffa + 22fe46b commit 269037a

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

activemodel/test/cases/api_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_initialize_with_nil_or_empty_hash_params_does_not_explode
5858

5959
def test_persisted_is_always_false
6060
object = BasicModel.new(attr: "value")
61-
assert object.persisted? == false
61+
assert_not object.persisted?
6262
end
6363

6464
def test_mixin_inclusion_chain

activemodel/test/cases/error_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ def test_initialize
214214
person = Person.new
215215
error = ActiveModel::Error.new(person, :name, foo: :bar)
216216

217-
assert error != person
217+
assert_not_equal error, person
218218
end
219219

220220
# details

activemodel/test/cases/model_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_initialize_with_nil_or_empty_hash_params_does_not_explode
5858

5959
def test_persisted_is_always_false
6060
object = BasicModel.new(attr: "value")
61-
assert object.persisted? == false
61+
assert_not object.persisted?
6262
end
6363

6464
def test_mixin_inclusion_chain

0 commit comments

Comments
 (0)