Merge pull request rails#54312 from BuonOmo/a-bit-faster

refactor(test): do not dump when not necessary

Author: byroot

activerecord/test/cases/adapters/postgresql/enum_test.rb

@@ -246,7 +246,7 @@ def test_schema_dump_scoped_to_schemas
         t.column :current_mood, :mood_in_test_schema
       end
 
-      output = dump_all_table_schema
+      output = dump_table_schema("postgresql_enums_in_test_schema")
 
       assert_includes output, 'create_enum "public.mood", ["sad", "ok", "happy"]'
       assert_includes output, 'create_enum "mood_in_test_schema", ["sad", "ok", "happy"]'

activerecord/test/cases/tasks/database_tasks_test.rb

@@ -370,7 +370,9 @@ def test_ensure_db_dir
           FileUtils.rm_rf(dir)
           assert_not File.file?(path)
 
-          ActiveRecord::Tasks::DatabaseTasks.dump_schema(db_config)
+          ActiveRecord::SchemaDumper.stub(:dump, "") do # Do not actually dump for test performances
+            ActiveRecord::Tasks::DatabaseTasks.dump_schema(db_config)
+          end
 
           assert File.file?(path)
         end
@@ -389,7 +391,9 @@ def test_db_dir_ignored_if_included_in_schema_dump
           FileUtils.rm_rf(dir)
           assert_not File.file?(path)
 
-          ActiveRecord::Tasks::DatabaseTasks.dump_schema(db_config)
+          ActiveRecord::SchemaDumper.stub(:dump, "") do # Do not actually dump for test performances
+            ActiveRecord::Tasks::DatabaseTasks.dump_schema(db_config)
+          end
 
           assert File.file?(path)
         end