Skip to content

Commit 2a9573c

Browse files
authored
Merge pull request rails#54446 from aidanharan/skip-insert-all-tests
Skip test if upsert/insert-duplicate not supported by database adapter
2 parents c50d860 + a9e6309 commit 2a9573c

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

activerecord/test/cases/insert_all_test.rb

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -864,6 +864,8 @@ def test_insert_all_when_table_name_contains_database
864864
end
865865

866866
def test_insert_all_with_unpersisted_records_triggers_deprecation
867+
skip unless supports_insert_on_duplicate_skip?
868+
867869
author = Author.create!(name: "Rafael")
868870
author.books.build(title: "Unpersisted Book")
869871

@@ -876,6 +878,8 @@ def test_insert_all_with_unpersisted_records_triggers_deprecation
876878
end
877879

878880
def test_insert_all_without_unpersisted_records_has_no_deprecation
881+
skip unless supports_insert_on_duplicate_skip?
882+
879883
author = Author.create!(name: "Rafael")
880884

881885
assert_not_deprecated(ActiveRecord.deprecator) do
@@ -884,6 +888,8 @@ def test_insert_all_without_unpersisted_records_has_no_deprecation
884888
end
885889

886890
def test_insert_with_unpersisted_records_triggers_deprecation
891+
skip unless supports_insert_on_duplicate_skip?
892+
887893
author = Author.create!(name: "Rafael")
888894
author.books.build(title: "Unpersisted Book")
889895

@@ -896,6 +902,8 @@ def test_insert_with_unpersisted_records_triggers_deprecation
896902
end
897903

898904
def test_insert_without_unpersisted_records_has_no_deprecation
905+
skip unless supports_insert_on_duplicate_skip?
906+
899907
author = Author.create!(name: "Rafael")
900908

901909
assert_not_deprecated(ActiveRecord.deprecator) do
@@ -924,6 +932,8 @@ def test_insert_all_bang_without_unpersisted_records_has_no_deprecation
924932
end
925933

926934
def test_upsert_all_with_unpersisted_record_triggers_deprecation
935+
skip unless supports_insert_on_duplicate_update?
936+
927937
author = Author.create!(name: "Rafael")
928938
author.books.build(title: "Unpersisted Book")
929939

@@ -936,6 +946,8 @@ def test_upsert_all_with_unpersisted_record_triggers_deprecation
936946
end
937947

938948
def test_upsert_all_without_unpersisted_records_has_no_deprecation
949+
skip unless supports_insert_on_duplicate_update?
950+
939951
author = Author.create!(name: "Rafael")
940952

941953
assert_not_deprecated(ActiveRecord.deprecator) do
@@ -944,6 +956,8 @@ def test_upsert_all_without_unpersisted_records_has_no_deprecation
944956
end
945957

946958
def test_upsert_with_unpersisted_record_triggers_deprecation
959+
skip unless supports_insert_on_duplicate_update?
960+
947961
author = Author.create!(name: "Rafael")
948962
author.books.build(title: "Unpersisted Book")
949963

@@ -956,6 +970,8 @@ def test_upsert_with_unpersisted_record_triggers_deprecation
956970
end
957971

958972
def test_upsert_without_unpersisted_records_has_no_deprecation
973+
skip unless supports_insert_on_duplicate_update?
974+
959975
author = Author.create!(name: "Rafael")
960976

961977
assert_not_deprecated(ActiveRecord.deprecator) do

0 commit comments

Comments
 (0)