Skip to content

Commit 2b987c3

Browse files
authored
Merge pull request rails#55256 from p8/activesupport/fix-typo-in-changelog
Correctly name `CurrentAttributes` in CHANGELOG [ci skip]
2 parents b51b272 + d3e80a4 commit 2b987c3

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

activesupport/CHANGELOG.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
*Xavier Noria*
1414

15-
* Improve `CurrentAttribute` and `ExecutionContext` state managment in test cases.
15+
* Improve `CurrentAttributes` and `ExecutionContext` state managment in test cases.
1616

1717
Previously these two global state would be entirely cleared out whenever calling
1818
into code that is wrapped by the Rails executor, typically Action Controller or
@@ -48,16 +48,16 @@
4848

4949
*Xavier Noria*
5050

51-
* Always clear `CurrentAttribute` instances.
51+
* Always clear `CurrentAttributes` instances.
5252

53-
Previously `CurrentAttribute` instance would be reset at the end of requests.
53+
Previously `CurrentAttributes` instance would be reset at the end of requests.
5454
Meaning its attributes would be re-initialized.
5555

5656
This is problematic because it assume these objects don't hold any state
5757
other than their declared attribute, which isn't always the case, and
5858
can lead to state leak across request.
5959

60-
Now `CurrentAttribute` instances are abandoned at the end of a request,
60+
Now `CurrentAttributes` instances are abandoned at the end of a request,
6161
and a new instance is created at the start of the next request.
6262

6363
*Jean Boussier*, *Janko Marohnić*

0 commit comments

Comments
 (0)