File tree Expand file tree Collapse file tree 1 file changed +4
-4
lines changed Expand file tree Collapse file tree 1 file changed +4
-4
lines changed Original file line number Diff line number Diff line change 12
12
13
13
* Xavier Noria *
14
14
15
- * Improve ` CurrentAttribute ` and ` ExecutionContext` state managment in test cases.
15
+ * Improve ` CurrentAttributes ` and ` ExecutionContext` state managment in test cases.
16
16
17
17
Previously these two global state would be entirely cleared out whenever calling
18
18
into code that is wrapped by the Rails executor, typically Action Controller or
48
48
49
49
* Xavier Noria *
50
50
51
- * Always clear ` CurrentAttribute ` instances.
51
+ * Always clear ` CurrentAttributes ` instances.
52
52
53
- Previously ` CurrentAttribute ` instance would be reset at the end of requests.
53
+ Previously ` CurrentAttributes ` instance would be reset at the end of requests.
54
54
Meaning its attributes would be re- initialized.
55
55
56
56
This is problematic because it assume these objects don' t hold any state
57
57
other than their declared attribute, which isn' t always the case , and
58
58
can lead to state leak across request.
59
59
60
- Now ` CurrentAttribute ` instances are abandoned at the end of a request,
60
+ Now ` CurrentAttributes ` instances are abandoned at the end of a request,
61
61
and a new instance is created at the start of the next request.
62
62
63
63
* Jean Boussier * , * Janko Marohni ć*
You can’t perform that action at this time.
0 commit comments