Merge pull request rails#46580 from jonathanhefner/deprecated_constant_accessor-vs-deprecated_constant_proxy

Prefer `deprecate_constant` over constant proxy

Author: jonathanhefner

actionview/lib/action_view/template/resolver.rb

@@ -10,7 +10,8 @@
 module ActionView
   # = Action View Resolver
   class Resolver
-    Path = ActiveSupport::Deprecation::DeprecatedConstantProxy.new("ActionView::Resolver::Path", "ActionView::TemplatePath", ActionView.deprecator)
+    include ActiveSupport::Deprecation::DeprecatedConstantAccessor
+    deprecate_constant "Path", "ActionView::TemplatePath", deprecator: ActionView.deprecator
 
     class PathParser # :nodoc:
       ParsedPath = Struct.new(:path, :details)

railties/lib/rails/generators/testing/behavior.rb

@@ -108,7 +108,8 @@ def migration_file_name(relative)
           end
       end
 
-      Behaviour = ActiveSupport::Deprecation::DeprecatedConstantProxy.new("Rails::Generators::Testing::Behaviour", "Rails::Generators::Testing::Behavior", Rails.deprecator)
+      include ActiveSupport::Deprecation::DeprecatedConstantAccessor
+      deprecate_constant "Behaviour", "Rails::Generators::Testing::Behavior", deprecator: Rails.deprecator
     end
   end
 end

railties/test/generators_test.rb

@@ -256,7 +256,7 @@ def test_hide_namespace
 
   def test_behaviour_aliases_behavior
     assert_deprecated(Rails.deprecator) do
-      assert_same Rails::Generators::Testing::Behavior, Rails::Generators::Testing::Behaviour.itself
+      assert_same Rails::Generators::Testing::Behavior, Rails::Generators::Testing::Behaviour
     end
   end
 end