Merge pull request rails#54298 from aliismayilov/index-exists-columns-optional

Make column name optional for `index_exists?`

Author: kamipo

activerecord/CHANGELOG.md

@@ -1,3 +1,10 @@
+*   Make column name optional for `index_exists?`.
+
+    This aligns well with `remove_index` signature as well, where
+    index name doesn't need to be derived from the column names.
+
+    *Ali Ismayiliov*
+
 *   Change the payload name of `sql.active_record` notification for eager
     loading from "SQL" to "#{model.name} Eager Load".
 

activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb

@@ -764,7 +764,7 @@ def index(column_name, **options)
       #  end
       #
       # See {connection.index_exists?}[rdoc-ref:SchemaStatements#index_exists?]
-      def index_exists?(column_name, **options)
+      def index_exists?(column_name = nil, **options)
         @base.index_exists?(name, column_name, **options)
       end
 

activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb

@@ -99,7 +99,7 @@ def indexes(table_name)
       #   # Check a valid index exists (PostgreSQL only)
       #   index_exists?(:suppliers, :company_id, valid: true)
       #
-      def index_exists?(table_name, column_name, **options)
+      def index_exists?(table_name, column_name = nil, **options)
         indexes(table_name).any? { |i| i.defined_for?(column_name, **options) }
       end
 

activerecord/lib/active_record/migration/compatibility.rb

@@ -445,7 +445,7 @@ def add_timestamps(table_name, **options)
           super
         end
 
-        def index_exists?(table_name, column_name, **options)
+        def index_exists?(table_name, column_name = nil, **options)
           column_names = Array(column_name).map(&:to_s)
           options[:name] =
             if options[:name].present?

activerecord/test/cases/migration/index_test.rb

@@ -178,6 +178,7 @@ def test_index_exists_with_custom_name_checks_columns
         connection.add_index :testings, [:foo, :bar], name: "my_index"
         assert connection.index_exists?(:testings, [:foo, :bar], name: "my_index")
         assert connection.index_exists?(:testings, [], name: "my_index")
+        assert connection.index_exists?(:testings, name: "my_index")
         assert_not connection.index_exists?(:testings, [:foo], name: "my_index")
       end