Skip to content

Commit 32228ff

Browse files
authored
Merge pull request rails#43650 from gmcgibbon/fixes_for_38957
Fixes for multi-service direct uploads
2 parents 27f17b9 + c22734b commit 32228ff

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

actiontext/app/javascript/actiontext/attachment_upload.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export class AttachmentUpload {
44
constructor(attachment, element) {
55
this.attachment = attachment
66
this.element = element
7-
this.directUpload = new DirectUpload(attachment.file, this.directUploadUrl, this)
7+
this.directUpload = new DirectUpload(attachment.file, this.directUploadUrl, this.directUploadToken, this.attachmentName, this)
88
}
99

1010
start() {
@@ -42,4 +42,11 @@ export class AttachmentUpload {
4242
get blobUrlTemplate() {
4343
return this.element.dataset.blobUrlTemplate
4444
}
45+
46+
get directUploadToken() {
47+
return this.element.getAttribute("data-direct-upload-token");
48+
}
49+
get attachmentName() {
50+
return this.element.getAttribute("data-direct-upload-attachment-name");
51+
}
4552
}

activestorage/test/controllers/direct_uploads_controller_test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class ActiveStorage::S3DirectUploadsControllerTest < ActionDispatch::Integration
2525
"library_ID": "12345"
2626
}
2727

28-
ActiveStorage::DirectUploadToken.stub(:verify_direct_upload_token, "local") do
28+
ActiveStorage::DirectUploadToken.stub(:verify_direct_upload_token, "s3") do
2929
post rails_direct_uploads_url, params: { blob: {
3030
filename: "hello.txt", byte_size: 6, checksum: checksum, content_type: "text/plain", metadata: metadata } }
3131
end
@@ -70,7 +70,7 @@ class ActiveStorage::GCSDirectUploadsControllerTest < ActionDispatch::Integratio
7070
"library_ID": "12345"
7171
}
7272

73-
ActiveStorage::DirectUploadToken.stub(:verify_direct_upload_token, "local") do
73+
ActiveStorage::DirectUploadToken.stub(:verify_direct_upload_token, "gcs") do
7474
post rails_direct_uploads_url, params: { blob: {
7575
filename: "hello.txt", byte_size: 6, checksum: checksum, content_type: "text/plain", metadata: metadata } }
7676
end
@@ -114,7 +114,7 @@ class ActiveStorage::AzureStorageDirectUploadsControllerTest < ActionDispatch::I
114114
"library_ID": "12345"
115115
}
116116

117-
ActiveStorage::DirectUploadToken.stub(:verify_direct_upload_token, "local") do
117+
ActiveStorage::DirectUploadToken.stub(:verify_direct_upload_token, "azure") do
118118
post rails_direct_uploads_url, params: { blob: {
119119
filename: "hello.txt", byte_size: 6, checksum: checksum, content_type: "text/plain", metadata: metadata } }
120120
end

0 commit comments

Comments
 (0)