Use NameError for missing association model class

Follow-up to rails#46605.

`AssociationReflection#automatic_inverse_of` expects a `NameError` to be
raised when a model class is missing.  rails#46605 changed the error to an
`ArgumentError`, which caused failures in isolated Active Record tests:

* https://buildkite.com/rails/rails/builds/91327#0184c50a-a38c-496e-b877-2946a3966cd9/1453-1463
* https://buildkite.com/rails/rails/builds/91327#0184c50a-a38e-4243-9b7c-82ff1728216a/1438-1448
* https://buildkite.com/rails/rails/builds/91327#0184c50a-a38e-4243-9b7c-82ff1728216a/1596-1606

Additionally, other `MacroReflection` subclasses raise a `NameError`,
not an `ArgumentError`, when the relevant class is missing.  (See
`MacroReflection#compute_class`.)

This commit changes the error back to `NameError`, and adds a regression
test to catch the problem even when the tests are not isolated.

This commit also reverts rails#46616 and rails#46619, which were only to address
the failures in the isolated tests.  For additional context, see rails#32113.

Author: jonathanhefner

activerecord/lib/active_record/reflection.rb

@@ -428,7 +428,7 @@ def compute_class(name)
         rescue NameError
           message = "Missing model class #{name} for the #{active_record}##{self.name} association."
           message += " You can specify a different model class with the :class_name option." unless options[:class_name]
-          raise ArgumentError, message
+          raise NameError, message
         end
 
         unless klass < ActiveRecord::Base

activerecord/test/cases/associations_test.rb

@@ -421,15 +421,15 @@ class ModelAssociatedToClassesThatDoNotExist < ActiveRecord::Base
   end
 
   def test_associations_raise_with_name_error_if_associated_to_classes_that_do_not_exist
-    assert_raises ArgumentError do
+    assert_raises NameError do
       ModelAssociatedToClassesThatDoNotExist.new.non_existent_has_one_class
     end
 
-    assert_raises ArgumentError do
+    assert_raises NameError do
       ModelAssociatedToClassesThatDoNotExist.new.non_existent_belongs_to_class
     end
 
-    assert_raises ArgumentError do
+    assert_raises NameError do
       ModelAssociatedToClassesThatDoNotExist.new.non_existent_has_many_classes
     end
   end

activerecord/test/cases/finder_test.rb

@@ -18,7 +18,6 @@
 require "models/customer"
 require "models/toy"
 require "models/matey"
-require "models/dog_lover"
 require "models/dog"
 require "models/car"
 require "models/tyre"

activerecord/test/cases/fixtures_test.rb

@@ -17,7 +17,6 @@
 require "models/computer"
 require "models/course"
 require "models/developer"
-require "models/dog_lover"
 require "models/dog"
 require "models/doubloon"
 require "models/essay"

activerecord/test/cases/nested_attributes_test.rb

@@ -2,7 +2,6 @@
 
 require "cases/helper"
 require "models/pirate"
-require "models/developer"
 require "models/ship"
 require "models/ship_part"
 require "models/bird"

activerecord/test/cases/reflection_test.rb

@@ -139,7 +139,7 @@ def test_irregular_reflection_class_name
   end
 
   def test_reflection_klass_not_found_with_no_class_name_option
-    error = assert_raise(ArgumentError) do
+    error = assert_raise(NameError) do
       UserWithInvalidRelation.reflect_on_association(:not_a_class).klass
     end
 
@@ -150,7 +150,7 @@ def test_reflection_klass_not_found_with_no_class_name_option
   end
 
   def test_reflection_klass_not_found_with_pointer_to_non_existent_class_name
-    error = assert_raise(ArgumentError) do
+    error = assert_raise(NameError) do
       UserWithInvalidRelation.reflect_on_association(:class_name_provided_not_a_class).klass
     end
 
@@ -560,6 +560,11 @@ def test_reflect_on_association_accepts_strings
     end
   end
 
+  def test_automatic_inverse_suppresses_name_error_for_association
+    reflection = UserWithInvalidRelation.reflect_on_association(:not_a_class)
+    assert_not reflection.dup.has_inverse? # dup to prevent global memoization
+  end
+
   private
     def assert_reflection(klass, association, options)
       assert reflection = klass.reflect_on_association(association)