Merge pull request rails#43670 from esparta/fix_race_conditions_test_cache

ActiveSupport: Fix some race conditions on test/cache/stores

Author: rafaelfranca

activesupport/test/cache/behaviors/cache_increment_decrement_behavior.rb

@@ -2,26 +2,28 @@
 
 module CacheIncrementDecrementBehavior
   def test_increment
-    @cache.write("foo", 1, raw: true)
-    assert_equal 1, @cache.read("foo", raw: true).to_i
-    assert_equal 2, @cache.increment("foo")
-    assert_equal 2, @cache.read("foo", raw: true).to_i
-    assert_equal 3, @cache.increment("foo")
-    assert_equal 3, @cache.read("foo", raw: true).to_i
+    key = SecureRandom.uuid
+    @cache.write(key, 1, raw: true)
+    assert_equal 1, @cache.read(key, raw: true).to_i
+    assert_equal 2, @cache.increment(key)
+    assert_equal 2, @cache.read(key, raw: true).to_i
+    assert_equal 3, @cache.increment(key)
+    assert_equal 3, @cache.read(key, raw: true).to_i
 
-    missing = @cache.increment("bar")
+    missing = @cache.increment(SecureRandom.alphanumeric)
     assert(missing.nil? || missing == 1)
   end
 
   def test_decrement
-    @cache.write("foo", 3, raw: true)
-    assert_equal 3, @cache.read("foo", raw: true).to_i
-    assert_equal 2, @cache.decrement("foo")
-    assert_equal 2, @cache.read("foo", raw: true).to_i
-    assert_equal 1, @cache.decrement("foo")
-    assert_equal 1, @cache.read("foo", raw: true).to_i
+    key = SecureRandom.uuid
+    @cache.write(key, 3, raw: true)
+    assert_equal 3, @cache.read(key, raw: true).to_i
+    assert_equal 2, @cache.decrement(key)
+    assert_equal 2, @cache.read(key, raw: true).to_i
+    assert_equal 1, @cache.decrement(key)
+    assert_equal 1, @cache.read(key, raw: true).to_i
 
-    missing = @cache.decrement("bar")
+    missing = @cache.decrement(SecureRandom.alphanumeric)
     assert(missing.nil? || missing == -1)
   end
 end