Merge pull request rails#54435 from xodene/xodene-default-mutability-attribute

Make Value type default to mutable

Author: byroot

activemodel/lib/active_model/type/boolean.rb

@@ -12,6 +12,7 @@ module Type
     # - Empty strings are coerced to +nil+.
     # - All other values will be coerced to +true+.
     class Boolean < Value
+      include Helpers::Immutable
       FALSE_VALUES = [
         false, 0,
         "0", :"0",

activemodel/lib/active_model/type/date.rb

@@ -24,6 +24,7 @@ module Type
     # String values are parsed using the ISO 8601 date format. Any other values
     # are cast using their +to_date+ method, if it exists.
     class Date < Value
+      include Helpers::Immutable
       include Helpers::Timezone
       include Helpers::AcceptsMultiparameterTime.new
 

activemodel/lib/active_model/type/decimal.rb

@@ -43,6 +43,7 @@ module Type
     #     attribute :weight, :decimal, precision: 24
     #   end
     class Decimal < Value
+      include Helpers::Immutable
       include Helpers::Numeric
       BIGDECIMAL_PRECISION = 18
 

activemodel/lib/active_model/type/float.rb

@@ -34,6 +34,7 @@ module Type
     # - <tt>"-Infinity"</tt> is cast to <tt>-Float::INFINITY</tt>.
     # - <tt>"NaN"</tt> is cast to +Float::NAN+.
     class Float < Value
+      include Helpers::Immutable
       include Helpers::Numeric
 
       def type

activemodel/lib/active_model/type/helpers.rb

@@ -3,5 +3,6 @@
 require "active_model/type/helpers/accepts_multiparameter_time"
 require "active_model/type/helpers/numeric"
 require "active_model/type/helpers/mutable"
+require "active_model/type/helpers/immutable"
 require "active_model/type/helpers/time_value"
 require "active_model/type/helpers/timezone"

activemodel/lib/active_model/type/helpers/immutable.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module ActiveModel
+  module Type
+    module Helpers # :nodoc: all
+      module Immutable
+        def mutable? # :nodoc:
+          false
+        end
+      end
+    end
+  end
+end

activemodel/lib/active_model/type/immutable_string.rb

@@ -35,6 +35,8 @@ module Type
     #
     #   person.active # => "aye"
     class ImmutableString < Value
+      include Helpers::Immutable
+
       def initialize(**args)
         @true  = -(args.delete(:true)&.to_s  || "t")
         @false = -(args.delete(:false)&.to_s || "f")

activemodel/lib/active_model/type/integer.rb

@@ -42,6 +42,7 @@ module Type
     #     attribute :age, :integer, limit: 6
     #   end
     class Integer < Value
+      include Helpers::Immutable
       include Helpers::Numeric
 
       # Column storage size in bytes.

activemodel/lib/active_model/type/time.rb

@@ -46,14 +46,6 @@ def type
         :time
       end
 
-      def mutable? # :nodoc:
-        # Time#zone can be mutated by #utc or #localtime
-        # However when serializing the time zone will always
-        # be coerced and even if the zone was mutated Time instances
-        # remain equal, so we don't need to implement `#changed_in_place?`
-        true
-      end
-
       def user_input_in_time_zone(value)
         return unless value.present?
 

activemodel/lib/active_model/type/value.rb

@@ -138,7 +138,7 @@ def serialized? # :nodoc:
       end
 
       def mutable? # :nodoc:
-        false
+        true
       end
 
       def as_json(*)