Merge pull request rails#54394 from fatkodima/fix-inverting-rename_enum_value

Fix inverting `rename_enum_value` when `:from`/`:to` are provided

Author: fatkodima

activerecord/lib/active_record/migration/command_recorder.rb

@@ -382,7 +382,8 @@ def invert_rename_enum_value(args)
             raise ActiveRecord::IrreversibleMigration, "rename_enum_value is only reversible if given a :from and :to option."
           end
 
-          [:rename_enum_value, [type_name, from: options[:to], to: options[:from]]]
+          options[:to], options[:from] = options[:from], options[:to]
+          [:rename_enum_value, [type_name, options]]
         end
 
         def invert_drop_virtual_table(args)

activerecord/test/cases/adapters/postgresql/invertible_migration_test.rb

@@ -35,6 +35,12 @@ def change
     end
   end
 
+  class RenameEnumValueMigration < SilentMigration
+    def change
+      rename_enum_value :color, from: "blue", to: "red"
+    end
+  end
+
   class AddAndValidateCheckConstraint < SilentMigration
     def change
       add_check_constraint :settings, "value >= 0", name: "positive_value", validate: false
@@ -97,6 +103,17 @@ def test_migrate_revert_drop_enum
     assert_equal [["color", ["blue", "green"]]], @connection.enum_types
   end
 
+  def test_migrate_revert_rename_enum_value
+    CreateEnumMigration.new.migrate(:up)
+    assert_equal [["color", ["blue", "green"]]], @connection.enum_types
+
+    RenameEnumValueMigration.new.migrate(:up)
+    assert_equal [["color", ["red", "green"]]], @connection.enum_types
+
+    RenameEnumValueMigration.new.migrate(:down)
+    assert_equal [["color", ["blue", "green"]]], @connection.enum_types
+  end
+
   def test_migrate_revert_add_and_validate_check_constraint
     @connection.create_table(:settings) do |t|
       t.integer :value