Remove deprecated ActiveRecord::Result#map! and ActiveRecord::Result#collect!

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove deprecated `ActiveRecord::Result#map!` and `ActiveRecord::Result#collect!`.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecated `ActiveRecord::Base.configurations.to_h`.
 
     *Rafael Mendonça França*

activerecord/lib/active_record/result.rb

@@ -72,11 +72,6 @@ def each(&block)
       end
     end
 
-    alias :map! :map
-    alias :collect! :map
-    deprecate "map!": :map
-    deprecate "collect!": :map
-
     # Returns true if there are no records, otherwise false.
     def empty?
       rows.empty?

activerecord/test/cases/result_test.rb

@@ -12,28 +12,6 @@ def result
       ])
     end
 
-    test "map! is deprecated" do
-      assert_deprecated do
-        result.map! { nil }
-      end
-      assert_equal [
-        { "col_1" => "row 1 col 1", "col_2" => "row 1 col 2" },
-        { "col_1" => "row 2 col 1", "col_2" => "row 2 col 2" },
-        { "col_1" => "row 3 col 1", "col_2" => "row 3 col 2" },
-      ], result.to_a
-    end
-
-    test "collect! is deprecated" do
-      assert_deprecated do
-        result.collect! { nil }
-      end
-      assert_equal [
-        { "col_1" => "row 1 col 1", "col_2" => "row 1 col 2" },
-        { "col_1" => "row 2 col 1", "col_2" => "row 2 col 2" },
-        { "col_1" => "row 3 col 1", "col_2" => "row 3 col 2" },
-      ], result.to_a
-    end
-
     test "includes_column?" do
       assert result.includes_column?("col_1")
       assert_not result.includes_column?("foo")

guides/source/7_0_release_notes.md

@@ -262,6 +262,8 @@ Please refer to the [Changelog][active-job] for detailed changes.
 
 *   Remove deprecated `ActiveRecord::Base.configurations.to_h`.
 
+*   Remove deprecated `ActiveRecord::Result#map!` and `ActiveRecord::Result#collect!`.
+
 ### Deprecations
 
 *   Deprecated `Rails.config.active_job.skip_after_callbacks_if_terminated`.