Merge pull request rails#54620 from zzak/re-54617

Ensure all railties tests require strict_warnings

Author: byroot

railties/Rakefile

@@ -116,6 +116,7 @@ namespace :test do
           ARGV.clear.concat test_options
           Rake.application = nil
 
+          require "../tools/strict_warnings"
           load file
         }
       else

railties/test/abstract_unit.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../tools/strict_warnings"
-
 ENV["RAILS_ENV"] ||= "test"
 
 require "stringio"

railties/test/configuration/middleware_stack_proxy_test.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../tools/strict_warnings"
 require "active_support"
 require "active_support/testing/autorun"
 require "rails/configuration"

railties/test/generators/argv_scrubber_test.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../tools/strict_warnings"
 require "active_support/test_case"
 require "active_support/testing/autorun"
 require "rails/generators/rails/app/app_generator"

railties/test/generators/generator_test.rb

@@ -1,6 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../tools/strict_warnings"
 require "active_support/test_case"
 require "active_support/testing/autorun"
 require "rails/generators/app_base"

railties/test/isolation/abstract_unit.rb

@@ -8,7 +8,6 @@
 #
 # It is also good to know what is the bare minimum to get
 # Rails booted up.
-require_relative "../../../tools/strict_warnings"
 require "fileutils"
 require "shellwords"
 

tools/strict_warnings.rb

@@ -30,7 +30,8 @@ def warn(message, ...)
 
     super
 
-    return unless message.include?(PROJECT_ROOT)
+    testpath = message[/test\/.*\.rb/]&.chomp || message
+    return unless message.include?(PROJECT_ROOT) || Pathname.new(testpath).exist?
     return if ALLOWED_WARNINGS.match?(message)
     return unless ENV["RAILS_STRICT_WARNINGS"] || ENV["BUILDKITE"]