Merge pull request rails#55149 from skipkayhil/hm-lint-head-body

Fix {Public,Debug}Exceptions rendering body for HEAD

Author: byroot

actionpack/CHANGELOG.md

@@ -1,3 +1,10 @@
+*   Always return empty body for HEAD requests in `PublicExceptions` and
+    `DebugExceptions`.
+
+    This is required by `Rack::Lint` (per RFC9110).
+
+    *Hartley McGuire*
+
 *   Add comprehensive support for HTTP Cache-Control request directives according to RFC 9111.
 
     Provides a `request.cache_control_directives` object that gives access to request cache directives:

actionpack/lib/action_dispatch/middleware/debug_exceptions.rb

@@ -65,7 +65,9 @@ def render_exception(request, exception, wrapper)
             content_type = Mime[:text]
           end
 
-          if api_request?(content_type)
+          if request.head?
+            render(wrapper.status_code, "", content_type)
+          elsif api_request?(content_type)
             render_for_api_request(content_type, wrapper)
           else
             render_for_browser_request(request, wrapper)

actionpack/lib/action_dispatch/middleware/public_exceptions.rb

@@ -28,7 +28,11 @@ def call(env)
       content_type = request.formats.first
       body = { status: status, error: Rack::Utils::HTTP_STATUS_CODES.fetch(status, Rack::Utils::HTTP_STATUS_CODES[500]) }
 
-      render(status, content_type, body)
+      if env["action_dispatch.original_request_method"] == "HEAD"
+        render_format(status, content_type, "")
+      else
+        render(status, content_type, body)
+      end
     end
 
     private

actionpack/test/dispatch/debug_exceptions_test.rb

@@ -183,6 +183,15 @@ def self.build_app(app, *args)
     assert boomer.closed, "Expected to close the response body"
   end
 
+  test "returns empty body on HEAD cascade pass" do
+    @app = DevelopmentApp
+
+    head "/pass"
+
+    assert_response 404
+    assert_equal "", body
+  end
+
   test "displays routes in a table when a RoutingError occurs" do
     @app = DevelopmentApp
     get "/pass", headers: { "action_dispatch.show_exceptions" => :all }

actionpack/test/dispatch/show_exceptions_test.rb

@@ -69,6 +69,32 @@ def setup
     assert_equal "", body
   end
 
+  test "rescue with no body for HEAD requests" do
+    head "/", env: { "action_dispatch.show_exceptions" => :all }
+    assert_response 500
+    assert_equal "", body
+
+    head "/bad_params", env: { "action_dispatch.show_exceptions" => :all }
+    assert_response 400
+    assert_equal "", body
+
+    head "/not_found", env: { "action_dispatch.show_exceptions" => :all }
+    assert_response 404
+    assert_equal "", body
+
+    head "/method_not_allowed", env: { "action_dispatch.show_exceptions" => :all }
+    assert_response 405
+    assert_equal "", body
+
+    head "/unknown_http_method", env: { "action_dispatch.show_exceptions" => :all }
+    assert_response 405
+    assert_equal "", body
+
+    head "/invalid_mimetype", headers: { "Accept" => "text/html,*", "action_dispatch.show_exceptions" => :all }
+    assert_response 406
+    assert_equal "", body
+  end
+
   test "localize rescue error page" do
     old_locale, I18n.locale = I18n.locale, :da