Merge pull request rails#54431 from matthewd/no-anon-modules

Defer creating the Active Model attribute-method module

Author: matthewd

activemodel/lib/active_model/attribute_methods.rb

@@ -373,7 +373,7 @@ def define_attribute_method_pattern(pattern, attr_name, owner:, as:, override: f
       #   person.name_short? # => NoMethodError
       #   person.first_name  # => NoMethodError
       def undefine_attribute_methods
-        generated_attribute_methods.module_eval do
+        @generated_attribute_methods&.module_eval do
           undef_method(*instance_methods)
         end
         attribute_method_patterns_cache.clear
@@ -402,7 +402,7 @@ def generated_attribute_methods
         end
 
         def instance_method_already_implemented?(method_name)
-          generated_attribute_methods.method_defined?(method_name)
+          @generated_attribute_methods&.method_defined?(method_name)
         end
 
         # The methods +method_missing+ and +respond_to?+ of this module are

activerecord/test/cases/base_test.rb

@@ -116,6 +116,10 @@ def test_generated_relation_methods_module_name
     assert_equal "Post::GeneratedRelationMethods", mod.inspect
   end
 
+  def test_no_anonymous_modules
+    assert_empty Photo.ancestors.select { |m| m.name.nil? }
+  end
+
   def test_arel_attribute_normalization
     assert_equal Post.arel_table["body"], Post.arel_table[:body]
     assert_equal Post.arel_table["body"], Post.arel_table[:text]