Unused default value that creates an Array object per each invocation

amatsuda · amatsuda · commit 4e7620b110bd · 2022-12-16T20:21:22.000+09:00
diff --git a/actionpack/lib/action_dispatch/http/mime_negotiation.rb b/actionpack/lib/action_dispatch/http/mime_negotiation.rb
@@ -72,7 +72,7 @@ def accepts
       #   GET /posts/5.xhtml | request.format => Mime[:html]
       #   GET /posts/5       | request.format => Mime[:html] or Mime[:js], or request.accepts.first
       #
-      def format(view_path = [])
+      def format(_view_path = nil)
         formats.first || Mime::NullType.instance
       end
 

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ def accepts`
`72`	`72`	`# GET /posts/5.xhtml \| request.format => Mime[:html]`
`73`	`73`	`# GET /posts/5 \| request.format => Mime[:html] or Mime[:js], or request.accepts.first`
`74`	`74`	`#`
`75`		`- def format(view_path = [])`
	`75`	`+ def format(_view_path = nil)`
`76`	`76`	`formats.first \|\| Mime::NullType.instance`
`77`	`77`	`end`
`78`	`78`