Remove deprecacated support to resolve connection using "primary" as connection specification name

Author: rafaelfranca

activerecord/CHANGELOG.md

@@ -1,3 +1,7 @@
+*   Remove deprecacated support to resolve connection using `"primary"` as connection specification name.
+
+    *Rafael Mendonça França*
+
 *   Remove deprecation warning when using `:interval` column is used in PostgreSQL database.
 
     Now, interval columns will return `ActiveSupport::Duration` objects instead of strings.

activerecord/lib/active_record/connection_adapters/abstract/connection_handler.rb

@@ -250,19 +250,8 @@ def retrieve_connection_pool(owner, role: ActiveRecord::Base.current_role, shard
         attr_reader :owner_to_pool_manager
 
         # Returns the pool manager for an owner.
-        #
-        # Using `"primary"` to look up the pool manager for `ActiveRecord::Base` is
-        # deprecated in favor of looking it up by `"ActiveRecord::Base"`.
-        #
-        # During the deprecation period, if `"primary"` is passed, the pool manager
-        # for `ActiveRecord::Base` will still be returned.
         def get_pool_manager(owner)
-          return owner_to_pool_manager[owner] if owner_to_pool_manager.key?(owner)
-
-          if owner == "primary"
-            ActiveSupport::Deprecation.warn("Using `\"primary\"` as a `connection_specification_name` is deprecated and will be removed in Rails 7.0.0. Please use `ActiveRecord::Base`.")
-            owner_to_pool_manager[Base.name]
-          end
+          owner_to_pool_manager[owner]
         end
 
         # Returns an instance of PoolConfig for a given adapter.

activerecord/test/cases/connection_adapters/connection_handler_test.rb

@@ -103,20 +103,6 @@ def test_establish_connection_with_primary_works_without_deprecation
           ActiveRecord::Base.configurations = old_config
         end
 
-        def test_retrieve_connection_shows_primary_deprecation_warning_when_established_on_active_record_base
-          old_config = ActiveRecord::Base.configurations
-          config = { "primary" => { "adapter" => "sqlite3", "database" => "test/db/primary.sqlite3" } }
-          ActiveRecord::Base.configurations = config
-
-          ActiveRecord::Base.establish_connection(:primary)
-
-          assert_deprecated { @handler.retrieve_connection("primary") }
-          assert_deprecated { @handler.remove_connection_pool("primary") }
-        ensure
-          ActiveRecord::Base.configurations = old_config
-          ActiveRecord::Base.establish_connection(:arunit)
-        end
-
         def test_establish_connection_using_3_level_config_defaults_to_default_env_primary_db
           previous_env, ENV["RAILS_ENV"] = ENV["RAILS_ENV"], "default_env"
 

guides/source/7_0_release_notes.md

@@ -116,6 +116,8 @@ Please refer to the [Changelog][active-record] for detailed changes.
     attribute :column, :string
     ```
 
+*   Remove deprecacated support to resolve connection using `"primary"` as connection specification name.
+
 ### Deprecations
 
 ### Notable changes