Merge pull request rails#54904 from Edouard-chin/ec-polymorphic-url

Fix `polymorphic_url` and `polymorphic_path` not working when routes are not loaded:

Author: byroot

railties/lib/rails/engine/lazy_route_set.rb

@@ -34,16 +34,6 @@ def optimize_routes_generation?
           Rails.application&.reload_routes_unless_loaded
           super
         end
-
-        def polymorphic_url(record_or_hash_or_array, options = {})
-          Rails.application&.reload_routes_unless_loaded
-          super
-        end
-
-        def polymorphic_path(record_or_hash_or_array, options = {})
-          Rails.application&.reload_routes_unless_loaded
-          super
-        end
       end
 
       def initialize(config = DEFAULT_CONFIG)
@@ -68,6 +58,11 @@ def call(req)
         super
       end
 
+      def polymorphic_mappings
+        Rails.application&.reload_routes_unless_loaded
+        super
+      end
+
       def draw(&block)
         Rails.application&.reload_routes_unless_loaded
         super

railties/test/engine/lazy_route_set_test.rb

@@ -52,6 +52,26 @@ class UsersController < ActionController::Base
         assert_equal(200, response.first)
       end
 
+      test "app lazily loads routes when polymorphic_url is called" do
+        app_file "test/integration/my_test.rb", <<~RUBY
+          require "test_helper"
+
+          class MyTest < ActionDispatch::IntegrationTest
+            test "polymorphic_url works" do
+              puts polymorphic_url(Comment.new)
+            end
+          end
+        RUBY
+
+        app_file "app/models/comment.rb", <<~RUBY
+          class Comment
+          end
+        RUBY
+
+        output = rails("test", "test/integration/my_test.rb")
+        assert_match("https://example.org", output)
+      end
+
       test "engine lazily loads routes when making a request" do
         require "#{app_path}/config/environment"
 
@@ -137,6 +157,7 @@ class User < ActiveRecord::Base
 
               resources :products
               resources :users, module: "rails/engine/lazy_route_set_test"
+              resolve("Comment") { "https://example.org" }
 
               mount Plugin::Engine, at: "/plugin"
             end