Merge pull request rails#54876 from the-spectator/tag_filter

Add support for filtering notes by tag in /rails/info/notes

Author: byroot

railties/lib/rails/info_controller.rb

@@ -33,9 +33,8 @@ def routes
   end
 
   def notes
-    @annotations = Rails::SourceAnnotationExtractor.new(
-      Rails::SourceAnnotationExtractor::Annotation.tags.join("|")
-    ).find(
+    tags = params[:tag].presence || Rails::SourceAnnotationExtractor::Annotation.tags.join("|")
+    @annotations = Rails::SourceAnnotationExtractor.new(tags).find(
       Rails::SourceAnnotationExtractor::Annotation.directories
     )
   end

railties/lib/rails/templates/rails/info/notes.html.erb

@@ -33,12 +33,35 @@
       background: #282828;
     }
   }
+
+  .filter {
+    display: flex;
+    width: 100%;
+    justify-content: flex-end;
+    align-items: center;
+  }
+
+  .filter label[for="tag"] {
+    margin-right: 10px;
+  }
+
+  .filter select[name="tag"] {
+    border-radius: 8px;
+    padding: 0.25em;
+  }
 </style>
 
 <h2>
   Notes
 </h2>
 
+<div class="filter">
+  <%= form_tag("/rails/info/notes", method: :get) do %>
+    <%= label_tag :tag, "Filter by Tag:" %>
+    <%= select_tag(:tag, options_for_select(Rails::SourceAnnotationExtractor::Annotation.tags, params[:tag]), { include_blank: "All", onchange: "this.form.submit();" }) %>
+  <% end %>
+</div>
+
 <table id="route_table" class="table">
   <thead>
     <th>File Name</th>