Merge pull request rails#54361 from Earlopain/arel-unused-block-warning

Fix two unused block warnings in arel

Author: byroot

actionpack/test/controller/filters_test.rb

@@ -514,7 +514,7 @@ def action_two
         @filters << "action_two"
       end
 
-      def non_yielding_action(&_)
+      def non_yielding_action(&)
         @filters << "it didn't yield"
       end
 

activejob/lib/active_job/enqueuing.rb

@@ -88,7 +88,7 @@ def perform_later(...)
       end
 
       private
-        def job_or_instantiate(*args, &_) # :doc:
+        def job_or_instantiate(*args, &) # :doc:
           args.first.is_a?(self) ? args.first : new(*args)
         end
         ruby2_keywords(:job_or_instantiate)

activemodel/lib/active_model/attribute.rb

@@ -38,7 +38,7 @@ def initialize(name, value_before_type_cast, type, original_attribute = nil, val
       @value = value unless value.nil?
     end
 
-    def value(&_)
+    def value(&)
       # `defined?` is cheaper than `||=` when we get back falsy values
       @value = type_cast(value_before_type_cast) unless defined?(@value)
       @value

activemodel/lib/active_model/type/big_integer.rb

@@ -44,7 +44,7 @@ def serialize_cast_value(value) # :nodoc:
         value
       end
 
-      def serializable?(value, &_)
+      def serializable?(value, &)
         true
       end
 

activemodel/lib/active_model/type/value.rb

@@ -25,7 +25,7 @@ def initialize(precision: nil, limit: nil, scale: nil)
       # by the database.  For example a boolean type can return +true+ if the
       # value parameter is a Ruby boolean, but may return +false+ if the value
       # parameter is some other object.
-      def serializable?(value, &_)
+      def serializable?(value, &)
         true
       end
 

activerecord/lib/active_record/statement_cache.rb

@@ -74,13 +74,13 @@ def <<(str)
         self
       end
 
-      def add_bind(obj)
+      def add_bind(obj, &)
         @binds << obj
         @parts << Substitute.new
         self
       end
 
-      def add_binds(binds, proc_for_binds = nil)
+      def add_binds(binds, proc_for_binds = nil, &)
         @binds.concat proc_for_binds ? binds.map(&proc_for_binds) : binds
         binds.size.times do |i|
           @parts << ", " unless i == 0

activerecord/lib/arel/collectors/bind.rb

@@ -18,7 +18,7 @@ def add_bind(bind, &)
         self
       end
 
-      def add_binds(binds, proc_for_binds = nil)
+      def add_binds(binds, proc_for_binds = nil, &)
         @binds.concat proc_for_binds ? binds.map(&proc_for_binds) : binds
         self
       end

activerecord/lib/arel/collectors/sql_string.rb

@@ -12,7 +12,7 @@ def initialize(*)
         @bind_index = 1
       end
 
-      def add_bind(bind)
+      def add_bind(bind, &)
         self << yield(@bind_index)
         @bind_index += 1
         self

activerecord/lib/arel/collectors/substitute_binds.rb

@@ -15,12 +15,12 @@ def <<(str)
         self
       end
 
-      def add_bind(bind)
+      def add_bind(bind, &)
         bind = bind.value_for_database if bind.respond_to?(:value_for_database)
         self << quoter.quote(bind)
       end
 
-      def add_binds(binds, proc_for_binds = nil)
+      def add_binds(binds, proc_for_binds = nil, &)
         self << binds.map { |bind| quoter.quote(bind) }.join(", ")
       end
 

activerecord/lib/arel/nodes/binary.rb

@@ -30,7 +30,7 @@ def eql?(other)
     end
 
     module FetchAttribute
-      def fetch_attribute
+      def fetch_attribute(&)
         if left.is_a?(Arel::Attributes::Attribute)
           yield left
         elsif right.is_a?(Arel::Attributes::Attribute)