Revert "Eliminate lease_connection call in TypeCaster::Connection"

This reverts commit 6dd1929.

This introduced a change in behaviour since type_for_attribute is aware of custom types but lookup_cast_type does not.

Additionally, since we no longer to use the table and column info to get attributes, this introduced an issue where attribute types were not be correctly found for some queries, where we were joining a table that has a different name than the name of the reflection for that association.

Author: andrewn617

activerecord/lib/active_record/table_metadata.rb

@@ -44,7 +44,7 @@ def associated_table(table_name)
         arel_table = arel_table.alias(table_name) if arel_table.name != table_name
         TableMetadata.new(association_klass, arel_table, reflection)
       else
-        type_caster = TypeCaster::Connection.new(klass)
+        type_caster = TypeCaster::Connection.new(klass, table_name)
         arel_table = Arel::Table.new(table_name, type_caster: type_caster)
         TableMetadata.new(nil, arel_table, reflection)
       end

activerecord/lib/active_record/type_caster/connection.rb

@@ -3,8 +3,9 @@
 module ActiveRecord
   module TypeCaster
     class Connection # :nodoc:
-      def initialize(klass)
+      def initialize(klass, table_name)
         @klass = klass
+        @table_name = table_name
       end
 
       def type_cast_for_database(attr_name, value)
@@ -13,8 +14,20 @@ def type_cast_for_database(attr_name, value)
       end
 
       def type_for_attribute(attr_name)
-        @klass.type_for_attribute(attr_name) || Type.default_value
+        schema_cache = @klass.schema_cache
+
+        if schema_cache.data_source_exists?(table_name)
+          column = schema_cache.columns_hash(table_name)[attr_name.to_s]
+          if column
+            type = @klass.lease_connection.lookup_cast_type_from_column(column)
+          end
+        end
+
+        type || Type.default_value
       end
+
+      private
+        attr_reader :table_name
     end
   end
 end